From 2494c2868d6e0eaaefd42f4fd2d260a8c35d240d Mon Sep 17 00:00:00 2001 From: Bart Van Assche Date: Wed, 22 Jan 2020 20:23:40 -0800 Subject: [PATCH] scsi: qla2xxx: Check locking assumptions at runtime in qla2x00_abort_srb() Document the locking assumptions this function relies on and also verify these locking assumptions at runtime. Cc: Quinn Tran Cc: Daniel Wagner Link: https://lore.kernel.org/r/20200123042345.23886-2-bvanassche@acm.org Acked-by: Himanshu Madhani Reviewed-by: Martin Wilck Reviewed-by: Roman Bolshakov Signed-off-by: Bart Van Assche Signed-off-by: Martin K. Petersen --- drivers/scsi/qla2xxx/qla_os.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/scsi/qla2xxx/qla_os.c b/drivers/scsi/qla2xxx/qla_os.c index b520a98..79387ac 100644 --- a/drivers/scsi/qla2xxx/qla_os.c +++ b/drivers/scsi/qla2xxx/qla_os.c @@ -1700,6 +1700,8 @@ static void qla2x00_abort_srb(struct qla_qpair *qp, srb_t *sp, const int res, bool ret_cmd; uint32_t ratov_j; + lockdep_assert_held(qp->qp_lock_ptr); + if (qla2x00_chip_is_down(vha)) { sp->done(sp, res); return; -- 2.7.4