From 2481ba527b995c5a4328085482e4917c48c12f57 Mon Sep 17 00:00:00 2001 From: "Eunki, Hong" Date: Fri, 5 Jan 2024 19:35:35 +0900 Subject: [PATCH] [NUI.Scene3D] Revert "Add AddLight API" Revert #5854 PR. We'd better found more good way to fix this issue. This reverts commit 0cb799167b61395984ee1da9d647f326aad852fa. --- .../src/internal/Interop/Interop.Libraries.cs | 1 - .../src/internal/Interop/Interop.SceneView.cs | 8 -------- .../src/public/Controls/SceneView.cs | 24 ---------------------- 3 files changed, 33 deletions(-) diff --git a/src/Tizen.NUI.Scene3D/src/internal/Interop/Interop.Libraries.cs b/src/Tizen.NUI.Scene3D/src/internal/Interop/Interop.Libraries.cs index 32d9762..06caee4 100755 --- a/src/Tizen.NUI.Scene3D/src/internal/Interop/Interop.Libraries.cs +++ b/src/Tizen.NUI.Scene3D/src/internal/Interop/Interop.Libraries.cs @@ -19,7 +19,6 @@ namespace Tizen.NUI.Scene3D { internal static partial class Libraries { - public const string Lib = "libdali2-csharp-binder.so"; public const string Scene3D = "libdali2-csharp-binder-scene3d.so"; } } diff --git a/src/Tizen.NUI.Scene3D/src/internal/Interop/Interop.SceneView.cs b/src/Tizen.NUI.Scene3D/src/internal/Interop/Interop.SceneView.cs index 8f5fd31..59e4f86 100755 --- a/src/Tizen.NUI.Scene3D/src/internal/Interop/Interop.SceneView.cs +++ b/src/Tizen.NUI.Scene3D/src/internal/Interop/Interop.SceneView.cs @@ -72,14 +72,6 @@ namespace Tizen.NUI.Scene3D [global::System.Runtime.InteropServices.DllImport(Libraries.Scene3D, EntryPoint = "CSharp_Dali_SceneView_GetImageBasedLightScaleFactor")] public static extern float GetImageBasedLightScaleFactor(global::System.Runtime.InteropServices.HandleRef sceneView); - // TODO : Implement AddLight API at native SceneView in future. Currently, let we just call Actor.Add - [global::System.Runtime.InteropServices.DllImport(Libraries.Lib, EntryPoint = "CSharp_Dali_Actor_Add")] - public static extern void AddLight(global::System.Runtime.InteropServices.HandleRef sceneView, global::System.Runtime.InteropServices.HandleRef light); - - // TODO : Implement RemoveLight API at native SceneView in future. Currently, let we just call Actor.Remove - [global::System.Runtime.InteropServices.DllImport(Libraries.Lib, EntryPoint = "CSharp_Dali_Actor_Remove")] - public static extern void RemoveLight(global::System.Runtime.InteropServices.HandleRef sceneView, global::System.Runtime.InteropServices.HandleRef light); - [global::System.Runtime.InteropServices.DllImport(Libraries.Scene3D, EntryPoint = "CSharp_Dali_SceneView_UseFramebuffer")] public static extern void UseFramebuffer(global::System.Runtime.InteropServices.HandleRef sceneView, bool useFramebuffer); diff --git a/src/Tizen.NUI.Scene3D/src/public/Controls/SceneView.cs b/src/Tizen.NUI.Scene3D/src/public/Controls/SceneView.cs index 61ceb2a..217a7a1 100755 --- a/src/Tizen.NUI.Scene3D/src/public/Controls/SceneView.cs +++ b/src/Tizen.NUI.Scene3D/src/public/Controls/SceneView.cs @@ -474,30 +474,6 @@ namespace Tizen.NUI.Scene3D } /// - /// Add Lights to this SceneView. - /// - /// The light what we want to add - // This will be public opened after ACR done. (Before ACR, need to be hidden as Inhouse API) - [EditorBrowsable(EditorBrowsableState.Never)] - public void AddLight(Light light) - { - Interop.SceneView.AddLight(SwigCPtr, Light.getCPtr(light)); - NDalicPINVOKE.ThrowExceptionIfExists(); - } - - /// - /// Remove Lights from this SceneView. - /// - /// The light what we want to remove - // This will be public opened after ACR done. (Before ACR, need to be hidden as Inhouse API) - [EditorBrowsable(EditorBrowsableState.Never)] - public void RemoveLight(Light light) - { - Interop.SceneView.RemoveLight(SwigCPtr, Light.getCPtr(light)); - NDalicPINVOKE.ThrowExceptionIfExists(); - } - - /// /// Sets SceneView's resolution manually. /// /// The input width. -- 2.7.4