From 244f5988056a54050129b06a03f9961af794f767 Mon Sep 17 00:00:00 2001 From: Kyle Date: Mon, 27 Jan 2014 14:01:11 -0600 Subject: [PATCH] logging fix for invalid response --- jenkinsapi/jenkinsbase.py | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/jenkinsapi/jenkinsbase.py b/jenkinsapi/jenkinsbase.py index bc5624b..eadfc6e 100644 --- a/jenkinsapi/jenkinsbase.py +++ b/jenkinsapi/jenkinsbase.py @@ -6,7 +6,6 @@ import ast import logging from jenkinsapi import config from jenkinsapi.custom_exceptions import JenkinsAPIException -log = logging.getLogger(__name__) class JenkinsBase(object): @@ -61,10 +60,12 @@ class JenkinsBase(object): def get_data(self, url, params=None): requester = self.get_jenkins_obj().requester response = requester.get_url(url, params) + if response.status_code != 200 : + response.raise_for_status() try: return ast.literal_eval(response.text) except Exception: - log.exception('Inappropriate content found at %s', url) + logging.exception('Inappropriate content found at %s', url) raise JenkinsAPIException('Cannot parse %s' % response.content) @classmethod -- 2.34.1