From 2449b194b26d9754a4eddcb83b61518daa7c29be Mon Sep 17 00:00:00 2001 From: Arkadiusz Sarwa Date: Wed, 23 Oct 2019 17:15:12 +0200 Subject: [PATCH] Fix incorrect assumption for pipeline cache hit The test incorrectly assumes that adding a pipeline creation flag bit VK_PIPELINE_CREATE_ALLOW_DERIVATIVES_BIT to only one pipeline still should cause a cache hit. Fixed the problem by adding the VK_PIPELINE_CREATE_ALLOW_DERIVATIVES_BIT flag bit to both pipelines. Affects: dEQP-VK.pipeline.creation_feedback.compute_tests.compute_stage Components: Vulkan VK-GL-CTS issue: 2068 Change-Id: Idb963219a4e894eee6a0bb3b1fc20797d5b0323e --- .../modules/vulkan/pipeline/vktPipelineCreationFeedbackTests.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/external/vulkancts/modules/vulkan/pipeline/vktPipelineCreationFeedbackTests.cpp b/external/vulkancts/modules/vulkan/pipeline/vktPipelineCreationFeedbackTests.cpp index 1344a90..6c116f3 100644 --- a/external/vulkancts/modules/vulkan/pipeline/vktPipelineCreationFeedbackTests.cpp +++ b/external/vulkancts/modules/vulkan/pipeline/vktPipelineCreationFeedbackTests.cpp @@ -1113,7 +1113,7 @@ void ComputeCacheTestInstance::buildPipeline (deUint32 ndx) 0u, // deInt32 basePipelineIndex; }; - if (ndx == PIPELINE_CACHE_NDX_NO_CACHE) + if (ndx != PIPELINE_CACHE_NDX_DERIVATIVE) { pipelineCreateInfo.flags = VK_PIPELINE_CREATE_ALLOW_DERIVATIVES_BIT; } -- 2.7.4