From 23f0fe4e1e7abc7963c9f5d58995d0121b3f0628 Mon Sep 17 00:00:00 2001 From: Steve Pfister Date: Fri, 30 Jul 2021 07:59:52 -0400 Subject: [PATCH] Enable skipped CodeDom tests on Android (#56581) Some C# and VB code generation tests were being skipped due to UseSystemResourceKeys being enabled. It no longer is. Fixes #50879 --- .../tests/System/CodeDom/Compiler/CSharpCodeGenerationTests.cs | 3 --- .../tests/System/CodeDom/Compiler/VBCodeGenerationTests.cs | 3 --- 2 files changed, 6 deletions(-) diff --git a/src/libraries/System.CodeDom/tests/System/CodeDom/Compiler/CSharpCodeGenerationTests.cs b/src/libraries/System.CodeDom/tests/System/CodeDom/Compiler/CSharpCodeGenerationTests.cs index 54b9b6a..b727fca 100644 --- a/src/libraries/System.CodeDom/tests/System/CodeDom/Compiler/CSharpCodeGenerationTests.cs +++ b/src/libraries/System.CodeDom/tests/System/CodeDom/Compiler/CSharpCodeGenerationTests.cs @@ -614,7 +614,6 @@ namespace System.CodeDom.Compiler.Tests [Fact] [SkipOnTargetFramework(TargetFrameworkMonikers.NetFramework)] - [ActiveIssue("https://github.com/dotnet/runtime/issues/50879", TestPlatforms.Android)] public void MetadataAttributes() { using (new ThreadCultureChange(CultureInfo.InvariantCulture)) @@ -1469,7 +1468,6 @@ namespace System.CodeDom.Compiler.Tests [Fact] [SkipOnTargetFramework(TargetFrameworkMonikers.NetFramework)] - [ActiveIssue("https://github.com/dotnet/runtime/issues/50879", TestPlatforms.Android)] public void RegionsSnippetsAndLinePragmas() { using (new ThreadCultureChange(CultureInfo.InvariantCulture)) @@ -2590,7 +2588,6 @@ namespace System.CodeDom.Compiler.Tests [Fact] [SkipOnTargetFramework(TargetFrameworkMonikers.NetFramework)] - [ActiveIssue("https://github.com/dotnet/runtime/issues/50879", TestPlatforms.Android)] public void ProviderSupports() { using (new ThreadCultureChange(CultureInfo.InvariantCulture)) diff --git a/src/libraries/System.CodeDom/tests/System/CodeDom/Compiler/VBCodeGenerationTests.cs b/src/libraries/System.CodeDom/tests/System/CodeDom/Compiler/VBCodeGenerationTests.cs index 06a31a1..2abddb4 100644 --- a/src/libraries/System.CodeDom/tests/System/CodeDom/Compiler/VBCodeGenerationTests.cs +++ b/src/libraries/System.CodeDom/tests/System/CodeDom/Compiler/VBCodeGenerationTests.cs @@ -580,7 +580,6 @@ namespace System.CodeDom.Compiler.Tests [Fact] [SkipOnTargetFramework(TargetFrameworkMonikers.NetFramework)] - [ActiveIssue("https://github.com/dotnet/runtime/issues/50879", TestPlatforms.Android)] public void MetadataAttributes() { using (new ThreadCultureChange(CultureInfo.InvariantCulture)) @@ -1400,7 +1399,6 @@ namespace System.CodeDom.Compiler.Tests [Fact] [SkipOnTargetFramework(TargetFrameworkMonikers.NetFramework)] - [ActiveIssue("https://github.com/dotnet/runtime/issues/50879", TestPlatforms.Android)] public void RegionsSnippetsAndLinePragmas() { using (new ThreadCultureChange(CultureInfo.InvariantCulture)) @@ -2362,7 +2360,6 @@ namespace System.CodeDom.Compiler.Tests [Fact] [SkipOnTargetFramework(TargetFrameworkMonikers.NetFramework)] - [ActiveIssue("https://github.com/dotnet/runtime/issues/50879", TestPlatforms.Android)] public void ProviderSupports() { using (new ThreadCultureChange(CultureInfo.InvariantCulture)) -- 2.7.4