From 2370e8539ca40ee80525e8549698426251a11053 Mon Sep 17 00:00:00 2001 From: Tom Tromey Date: Tue, 18 Dec 2012 19:24:40 +0000 Subject: [PATCH] * cli/cli-cmds.c (_initialize_cli_cmds): Remove "document", "define", "while", and "if" commands. * cli/cli-script.c (while_command, if_command, define_command) (document_command): Now static. (_initialize_cli_script): New function. * cli/cli-script.h (while_command, if_command, define_command) (document_command): Don't declare. --- gdb/ChangeLog | 10 ++++++++++ gdb/cli/cli-cmds.c | 23 ----------------------- gdb/cli/cli-script.c | 39 +++++++++++++++++++++++++++++++++++---- gdb/cli/cli-script.h | 8 -------- 4 files changed, 45 insertions(+), 35 deletions(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 4cbc9ab..cb57bec 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,5 +1,15 @@ 2012-12-12 Tom Tromey + * cli/cli-cmds.c (_initialize_cli_cmds): Remove "document", + "define", "while", and "if" commands. + * cli/cli-script.c (while_command, if_command, define_command) + (document_command): Now static. + (_initialize_cli_script): New function. + * cli/cli-script.h (while_command, if_command, define_command) + (document_command): Don't declare. + +2012-12-12 Tom Tromey + * cli/cli-cmds.c (_initialize_cli_cmds): New function. (init_cli_cmds): Move most code into new function. diff --git a/gdb/cli/cli-cmds.c b/gdb/cli/cli-cmds.c index 6ee3e3c..e0dc145 100644 --- a/gdb/cli/cli-cmds.c +++ b/gdb/cli/cli-cmds.c @@ -1705,16 +1705,6 @@ use \"\\n\" if you want a newline to be printed.\n\ Since leading and trailing whitespace are ignored in command arguments,\n\ if you want to print some you must use \"\\\" before leading whitespace\n\ to be printed or after trailing whitespace.")); - add_com ("document", class_support, document_command, _("\ -Document a user-defined command.\n\ -Give command name as argument. Give documentation on following lines.\n\ -End with a line of just \"end\".")); - add_com ("define", class_support, define_command, _("\ -Define a new command name. Command name is argument.\n\ -Definition appears on following lines, one command per line.\n\ -End with a line of just \"end\".\n\ -Use the \"document\" command to give documentation for the new command.\n\ -Commands defined in this way may have up to ten arguments.")); add_setshow_enum_cmd ("script-extension", class_support, script_ext_enums, &script_ext_mode, _("\ @@ -1782,19 +1772,6 @@ the previous command number shown."), add_cmd ("version", no_set_class, show_version, _("Show what version of GDB this is."), &showlist); - add_com ("while", class_support, while_command, _("\ -Execute nested commands WHILE the conditional expression is non zero.\n\ -The conditional expression must follow the word `while' and must in turn be\n\ -followed by a new line. The nested commands must be entered one per line,\n\ -and should be terminated by the word `end'.")); - - add_com ("if", class_support, if_command, _("\ -Execute nested commands once IF the conditional expression is non zero.\n\ -The conditional expression must follow the word `if' and must in turn be\n\ -followed by a new line. The nested commands must be entered one per line,\n\ -and should be terminated by the word 'else' or `end'. If an else clause\n\ -is used, the same rules apply to its nested commands as to the first ones.")); - /* If target is open when baud changes, it doesn't take effect until the next open (I think, not sure). */ add_setshow_zinteger_cmd ("remotebaud", no_class, &baud_rate, _("\ diff --git a/gdb/cli/cli-script.c b/gdb/cli/cli-script.c index 6a31dd0..a73ca71 100644 --- a/gdb/cli/cli-script.c +++ b/gdb/cli/cli-script.c @@ -598,7 +598,7 @@ execute_control_command_untraced (struct command_line *cmd) /* "while" command support. Executes a body of statements while the loop condition is nonzero. */ -void +static void while_command (char *arg, int from_tty) { struct command_line *command = NULL; @@ -622,7 +622,7 @@ while_command (char *arg, int from_tty) /* "if" command support. Execute either the true or false arm depending on the value of the if conditional. */ -void +static void if_command (char *arg, int from_tty) { struct command_line *command = NULL; @@ -1448,7 +1448,7 @@ user_defined_command (char *ignore, int from_tty) { } -void +static void define_command (char *comname, int from_tty) { #define MAX_TMPBUF 128 @@ -1565,7 +1565,7 @@ define_command (char *comname, int from_tty) } } -void +static void document_command (char *comname, int from_tty) { struct command_line *doclines; @@ -1700,3 +1700,34 @@ show_user_1 (struct cmd_list_element *c, char *prefix, char *name, fputs_filtered ("\n", stream); } + + +initialize_file_ftype _initialize_cli_script; + +void +_initialize_cli_script (void) +{ + add_com ("document", class_support, document_command, _("\ +Document a user-defined command.\n\ +Give command name as argument. Give documentation on following lines.\n\ +End with a line of just \"end\".")); + add_com ("define", class_support, define_command, _("\ +Define a new command name. Command name is argument.\n\ +Definition appears on following lines, one command per line.\n\ +End with a line of just \"end\".\n\ +Use the \"document\" command to give documentation for the new command.\n\ +Commands defined in this way may have up to ten arguments.")); + + add_com ("while", class_support, while_command, _("\ +Execute nested commands WHILE the conditional expression is non zero.\n\ +The conditional expression must follow the word `while' and must in turn be\n\ +followed by a new line. The nested commands must be entered one per line,\n\ +and should be terminated by the word `end'.")); + + add_com ("if", class_support, if_command, _("\ +Execute nested commands once IF the conditional expression is non zero.\n\ +The conditional expression must follow the word `if' and must in turn be\n\ +followed by a new line. The nested commands must be entered one per line,\n\ +and should be terminated by the word 'else' or `end'. If an else clause\n\ +is used, the same rules apply to its nested commands as to the first ones.")); +} diff --git a/gdb/cli/cli-script.h b/gdb/cli/cli-script.h index 999c4e8..a430c4b 100644 --- a/gdb/cli/cli-script.h +++ b/gdb/cli/cli-script.h @@ -25,14 +25,6 @@ struct cmd_list_element; extern void script_from_file (FILE *stream, const char *file); -extern void document_command (char *, int); - -extern void define_command (char *, int); - -extern void while_command (char *arg, int from_tty); - -extern void if_command (char *arg, int from_tty); - extern void show_user_1 (struct cmd_list_element *c, char *prefix, char *name, struct ui_file *stream); -- 2.7.4