From 2269b42e02cee8680b0b9ff4923a5a9c3f8df482 Mon Sep 17 00:00:00 2001 From: Jarkko Hietaniemi Date: Thu, 28 Dec 2000 23:34:08 +0000 Subject: [PATCH] Make some panic messages a bit more logical. p4raw-id: //depot/perl@8244 --- doop.c | 6 +++--- pod/perldiag.pod | 14 +++++++------- pp.c | 2 +- pp_hot.c | 4 ++-- 4 files changed, 13 insertions(+), 13 deletions(-) diff --git a/doop.c b/doop.c index 7acad60..ea65a68 100644 --- a/doop.c +++ b/doop.c @@ -48,7 +48,7 @@ S_do_trans_simple(pTHX_ SV *sv) tbl = (short*)cPVOP->op_pv; if (!tbl) - Perl_croak(aTHX_ "panic: do_trans"); + Perl_croak(aTHX_ "panic: do_trans_simple"); s = (U8*)SvPV(sv, len); send = s + len; @@ -107,7 +107,7 @@ S_do_trans_count(pTHX_ SV *sv)/* SPC - OK */ tbl = (short*)cPVOP->op_pv; if (!tbl) - Perl_croak(aTHX_ "panic: do_trans"); + Perl_croak(aTHX_ "panic: do_trans_count"); s = (U8*)SvPV(sv, len); send = s + len; @@ -147,7 +147,7 @@ S_do_trans_complex(pTHX_ SV *sv)/* SPC - NOT OK */ tbl = (short*)cPVOP->op_pv; if (!tbl) - Perl_croak(aTHX_ "panic: do_trans"); + Perl_croak(aTHX_ "panic: do_trans_complex"); s = (U8*)SvPV(sv, len); send = s + len; diff --git a/pod/perldiag.pod b/pod/perldiag.pod index be15926..22a24be 100644 --- a/pod/perldiag.pod +++ b/pod/perldiag.pod @@ -2405,23 +2405,19 @@ reference. (P) We popped the context stack to an eval context, and then discovered it wasn't an eval context. -=item panic: do_match +=item panic: pp_match (P) The internal pp_match() routine was called with invalid operational data. -=item panic: do_split - -(P) Something terrible went wrong in setting up for the split. - =item panic: do_subst (P) The internal pp_subst() routine was called with invalid operational data. -=item panic: do_trans +=item panic: do_trans_%s -(P) The internal do_trans() routine was called with invalid operational +(P) The internal do_trans routines were called with invalid operational data. =item panic: frexp @@ -2513,6 +2509,10 @@ and freeing temporaries and lexicals from. (P) The foreach iterator got called in a non-loop context frame. +=item panic: pp_split + +(P) Something terrible went wrong in setting up for the split. + =item panic: realloc (P) Something requested a negative number of bytes of realloc. diff --git a/pp.c b/pp.c index 8914104..4a46de5 100644 --- a/pp.c +++ b/pp.c @@ -5772,7 +5772,7 @@ PP(pp_split) pm = (PMOP*)POPs; #endif if (!pm || !s) - DIE(aTHX_ "panic: do_split"); + DIE(aTHX_ "panic: pp_split"); rx = pm->op_pmregexp; TAINT_IF((pm->op_pmflags & PMf_LOCALE) && diff --git a/pp_hot.c b/pp_hot.c index a24aa1d..c362665 100644 --- a/pp_hot.c +++ b/pp_hot.c @@ -1184,7 +1184,7 @@ PP(pp_match) s = SvPV(TARG, len); strend = s + len; if (!s) - DIE(aTHX_ "panic: do_match"); + DIE(aTHX_ "panic: pp_match"); rxtainted = ((pm->op_pmdynflags & PMdf_TAINTED) || (PL_tainted && (pm->op_pmflags & PMf_RETAINT))); TAINT_NOT; @@ -1850,7 +1850,7 @@ PP(pp_subst) force_it: if (!pm || !s) - DIE(aTHX_ "panic: do_subst"); + DIE(aTHX_ "panic: pp_subst"); strend = s + len; maxiters = 2*(strend - s) + 10; /* We can match twice at each -- 2.7.4