From 21fa6b4e8a5605a7a3ea62bb6fe8623eecab3e6d Mon Sep 17 00:00:00 2001 From: Hermet Park Date: Wed, 2 Nov 2016 19:00:10 +0900 Subject: [PATCH] c++: add missing doc to private member function, also change the function name. We have a rule to add underscore for private member function name. Change-Id: I0e854309fd0f72f7d2a8592b20007aa1acd75fee --- src/include/interface/UiIfaceView.h | 8 +++++++- src/lib/interface/UiIfaceView.cpp | 2 +- src/lib/interface/UiIfaceViewmgr.cpp | 6 +++--- 3 files changed, 11 insertions(+), 5 deletions(-) diff --git a/src/include/interface/UiIfaceView.h b/src/include/interface/UiIfaceView.h index 204863c..3461106 100644 --- a/src/include/interface/UiIfaceView.h +++ b/src/include/interface/UiIfaceView.h @@ -337,7 +337,13 @@ private: */ void _setViewmgr(UiIfaceViewmgr *viewmgr); - void setPopping(bool popping); + /** + * @brief Sets a flag that indicates this view is popping. + * + * @param[in] popping @c true if this view is popping, otherwise @c false + * + */ + void _setPopping(bool popping); /** * @brief Return the viewmgr instance. diff --git a/src/lib/interface/UiIfaceView.cpp b/src/lib/interface/UiIfaceView.cpp index 8817dcf..ac6fb6d 100644 --- a/src/lib/interface/UiIfaceView.cpp +++ b/src/lib/interface/UiIfaceView.cpp @@ -441,7 +441,7 @@ void UiIfaceView::onLanguageChanged(const char *language) { } -void UiIfaceView::setPopping(bool popping) +void UiIfaceView::_setPopping(bool popping) { this->_impl->_popping = popping; } diff --git a/src/lib/interface/UiIfaceViewmgr.cpp b/src/lib/interface/UiIfaceViewmgr.cpp index 0bfee94..385061b 100644 --- a/src/lib/interface/UiIfaceViewmgr.cpp +++ b/src/lib/interface/UiIfaceViewmgr.cpp @@ -188,7 +188,7 @@ void UiIfaceViewmgrImpl::popViewFinished(UiIfaceView *view) //The previous view has been popped. It should become activate. view->onActivate(); this->setEventBlock(view, false); - view->setPopping(false); + view->_setPopping(false); } UiIfaceViewmgrImpl::UiIfaceViewmgrImpl(UiIfaceViewmgr* viewmgr) @@ -284,7 +284,7 @@ int UiIfaceViewmgrImpl::popView() return UI_VIEWMGR_ERROR_NONE; } - view->setPopping(true); + view->_setPopping(true); view->onDeactivate(); this->setEventBlock(view, true); @@ -293,7 +293,7 @@ int UiIfaceViewmgrImpl::popView() //previous page is to be an active page. auto nx = prev(this->_viewList.end(), 2); auto pview = *nx; - pview->setPopping(true); + pview->_setPopping(true); pview->onLoad(); pview->onDeactivate(); this->setEventBlock(pview, true); -- 2.34.1