From 21ed55d9122ef485c4180f127fecd13a50f5cc7f Mon Sep 17 00:00:00 2001 From: "dcarney@chromium.org" Date: Tue, 17 Sep 2013 12:23:12 +0000 Subject: [PATCH] remove js_accessor_ics flag R=mstarzinger@chromium.org BUG= Review URL: https://codereview.chromium.org/24200002 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16768 ce2b1a6d-e550-0410-aec6-3dcde31c8c00 --- src/flag-definitions.h | 1 - src/ic.cc | 9 +++------ test/cctest/test-accessors.cc | 2 +- 3 files changed, 4 insertions(+), 8 deletions(-) diff --git a/src/flag-definitions.h b/src/flag-definitions.h index cc153af..4167c42 100644 --- a/src/flag-definitions.h +++ b/src/flag-definitions.h @@ -544,7 +544,6 @@ DEFINE_bool(use_idle_notification, true, "Use idle notification to reduce memory footprint.") // ic.cc DEFINE_bool(use_ic, true, "use inline caching") -DEFINE_bool(js_accessor_ics, false, "create ics for js accessors") // macro-assembler-ia32.cc DEFINE_bool(native_code_counters, false, diff --git a/src/ic.cc b/src/ic.cc index 992df1b..163172d 100644 --- a/src/ic.cc +++ b/src/ic.cc @@ -1365,8 +1365,7 @@ Handle LoadIC::ComputeLoadHandler(LookupResult* lookup, Handle function = Handle::cast(getter); CallOptimization call_optimization(function); if (call_optimization.is_simple_api_call() && - call_optimization.IsCompatibleReceiver(*receiver) && - FLAG_js_accessor_ics) { + call_optimization.IsCompatibleReceiver(*receiver)) { return isolate()->stub_cache()->ComputeLoadCallback( name, receiver, holder, call_optimization); } @@ -1577,8 +1576,7 @@ Handle KeyedLoadIC::ComputeLoadHandler(LookupResult* lookup, Handle function = Handle::cast(getter); CallOptimization call_optimization(function); if (call_optimization.is_simple_api_call() && - call_optimization.IsCompatibleReceiver(*receiver) && - FLAG_js_accessor_ics) { + call_optimization.IsCompatibleReceiver(*receiver)) { return isolate()->stub_cache()->ComputeKeyedLoadCallback( name, receiver, holder, call_optimization); } @@ -1856,8 +1854,7 @@ Handle StoreIC::ComputeStoreMonomorphic(LookupResult* lookup, Handle function = Handle::cast(setter); CallOptimization call_optimization(function); if (call_optimization.is_simple_api_call() && - call_optimization.IsCompatibleReceiver(*receiver) && - FLAG_js_accessor_ics) { + call_optimization.IsCompatibleReceiver(*receiver)) { return isolate()->stub_cache()->ComputeStoreCallback( name, receiver, holder, call_optimization, strict_mode); } diff --git a/test/cctest/test-accessors.cc b/test/cctest/test-accessors.cc index 2aaac92..ce8ab19 100644 --- a/test/cctest/test-accessors.cc +++ b/test/cctest/test-accessors.cc @@ -554,7 +554,7 @@ THREADED_TEST(JSONStringifyNamedInterceptorObject) { } -THREADED_TEST(CrossContextAccess) { +THREADED_TEST(AccessorPropertyCrossContext) { LocalContext env; v8::Isolate* isolate = env->GetIsolate(); v8::HandleScope scope(isolate); -- 2.7.4