From 2178d496c60a0a0bf28f09c8fcbb4928d8c57edd Mon Sep 17 00:00:00 2001 From: Brian Gix Date: Tue, 23 Feb 2021 10:51:20 -0800 Subject: [PATCH] tools: Cleanup deprecated symbolic file permissions Signed-off-by: Anuj Jain Signed-off-by: Ayush Garg --- tools/btsnoop.c | 3 +-- tools/create-image.c | 3 +-- tools/hcidump.c | 2 +- tools/rctest.c | 3 +-- 4 files changed, 4 insertions(+), 7 deletions(-) diff --git a/tools/btsnoop.c b/tools/btsnoop.c index bb10916..599b13f 100644 --- a/tools/btsnoop.c +++ b/tools/btsnoop.c @@ -60,8 +60,7 @@ static int create_btsnoop(const char *path) ssize_t written; int fd; - fd = open(path, O_WRONLY | O_CREAT | O_TRUNC | O_CLOEXEC, - S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH); + fd = open(path, O_WRONLY | O_CREAT | O_TRUNC | O_CLOEXEC, 0644); if (fd < 0) { perror("failed to output file"); return -1; diff --git a/tools/create-image.c b/tools/create-image.c index 06c2af6..3f0586f 100755 --- a/tools/create-image.c +++ b/tools/create-image.c @@ -52,8 +52,7 @@ static unsigned int ino_cnt = 721; -#define REG_EXE S_IFREG | \ - S_IRUSR | S_IXUSR | S_IRGRP | S_IXGRP | S_IROTH | S_IXOTH +#define REG_EXE S_IFREG | 0555 static const struct { const char *source; diff --git a/tools/hcidump.c b/tools/hcidump.c index 6df1b85..c324cce 100644 --- a/tools/hcidump.c +++ b/tools/hcidump.c @@ -478,7 +478,7 @@ static int open_file(char *file, int mode, unsigned long flags) else open_flags = O_RDONLY; - fd = open(file, open_flags, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH); + fd = open(file, open_flags, 0644); if (fd < 0) { perror("Can't open dump file"); exit(1); diff --git a/tools/rctest.c b/tools/rctest.c index f55a927..b19b156 100755 --- a/tools/rctest.c +++ b/tools/rctest.c @@ -630,8 +630,7 @@ static void automated_send_recv() do_listen(recv_mode); } - save_fd = open(savefile, O_CREAT | O_WRONLY, - S_IRUSR | S_IWUSR); + save_fd = open(savefile, O_CREAT | O_WRONLY, 0600); if (save_fd < 0) syslog(LOG_ERR, "Failed to open file to save data"); -- 2.7.4