From 21504e6477bc1cd6bbb84edcc65ddddb172a465f Mon Sep 17 00:00:00 2001 From: "vsevik@chromium.org" Date: Fri, 23 Sep 2011 14:35:07 +0000 Subject: [PATCH] Web Inspector: Add context menu action to navigate from resources panel resource to network panel. https://bugs.webkit.org/show_bug.cgi?id=68657 Reviewed by Yury Semikhatsky. * English.lproj/localizedStrings.js: * inspector/front-end/NetworkPanel.js: (WebInspector.NetworkPanel.prototype.showAnchorLocation): (WebInspector.NetworkPanel.prototype.revealAndHighlightResource): * inspector/front-end/ResourcesPanel.js: (WebInspector.FrameResourceTreeElement.prototype._handleContextMenuEvent): (WebInspector.FrameResourceTreeElement.prototype._appendOpenInNetworkPanelAction): * inspector/front-end/inspector.js: (WebInspector.openInNetworkPanelLabel): (WebInspector.openRequestInNetworkPanel): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95801 268f45cc-cd09-0410-ab3c-d52691b4dbfc --- Source/WebCore/ChangeLog | 18 ++++++++++++++++++ Source/WebCore/English.lproj/localizedStrings.js | Bin 64406 -> 64682 bytes Source/WebCore/inspector/front-end/NetworkPanel.js | 4 ++++ .../WebCore/inspector/front-end/ResourcesPanel.js | 9 +++++++++ Source/WebCore/inspector/front-end/inspector.js | 11 +++++++++++ 5 files changed, 42 insertions(+) diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog index 8c7422b..2a97daf 100644 --- a/Source/WebCore/ChangeLog +++ b/Source/WebCore/ChangeLog @@ -1,3 +1,21 @@ +2011-09-23 Vsevolod Vlasov + + Web Inspector: Add context menu action to navigate from resources panel resource to network panel. + https://bugs.webkit.org/show_bug.cgi?id=68657 + + Reviewed by Yury Semikhatsky. + + * English.lproj/localizedStrings.js: + * inspector/front-end/NetworkPanel.js: + (WebInspector.NetworkPanel.prototype.showAnchorLocation): + (WebInspector.NetworkPanel.prototype.revealAndHighlightResource): + * inspector/front-end/ResourcesPanel.js: + (WebInspector.FrameResourceTreeElement.prototype._handleContextMenuEvent): + (WebInspector.FrameResourceTreeElement.prototype._appendOpenInNetworkPanelAction): + * inspector/front-end/inspector.js: + (WebInspector.openInNetworkPanelLabel): + (WebInspector.openRequestInNetworkPanel): + 2011-09-23 Deepak Sherveghar [Gtk] Title attribute is not respected on option elements. diff --git a/Source/WebCore/English.lproj/localizedStrings.js b/Source/WebCore/English.lproj/localizedStrings.js index dc93a80e32e5e0af670d96ee6af441fad181dabb..13eed344eb558a02e1a8819b7ce4dea2f91f4cd0 100644 GIT binary patch delta 120 zcmbRCoq5$y<_*$?!kG+t345A<_*$?oAryTy8t#y2Fw5e diff --git a/Source/WebCore/inspector/front-end/NetworkPanel.js b/Source/WebCore/inspector/front-end/NetworkPanel.js index 5463d0b..e9dec7f 100644 --- a/Source/WebCore/inspector/front-end/NetworkPanel.js +++ b/Source/WebCore/inspector/front-end/NetworkPanel.js @@ -1385,7 +1385,11 @@ WebInspector.NetworkPanel.prototype = { showAnchorLocation: function(anchor) { var resource = this._resourceByAnchor(anchor); + this.revealAndHighlightResource(resource) + }, + revealAndHighlightResource: function(resource) + { this._toggleGridMode(); if (resource) this._networkLogView.revealAndHighlightResource(resource); diff --git a/Source/WebCore/inspector/front-end/ResourcesPanel.js b/Source/WebCore/inspector/front-end/ResourcesPanel.js index 773adbf..fe341ca 100644 --- a/Source/WebCore/inspector/front-end/ResourcesPanel.js +++ b/Source/WebCore/inspector/front-end/ResourcesPanel.js @@ -1235,10 +1235,19 @@ WebInspector.FrameResourceTreeElement.prototype = { { var contextMenu = new WebInspector.ContextMenu(); contextMenu.appendItem(WebInspector.openLinkExternallyLabel(), WebInspector.openResource.bind(WebInspector, this._resource.url, false)); + this._appendOpenInNetworkPanelAction(contextMenu, event); this._appendSaveAsAction(contextMenu, event); contextMenu.show(event); }, + _appendOpenInNetworkPanelAction: function(contextMenu, event) + { + if (!this._resource.requestId) + return; + + contextMenu.appendItem(WebInspector.openInNetworkPanelLabel(), WebInspector.openRequestInNetworkPanel.bind(WebInspector, this._resource)); + }, + _appendSaveAsAction: function(contextMenu, event) { if (!Preferences.saveAsAvailable) diff --git a/Source/WebCore/inspector/front-end/inspector.js b/Source/WebCore/inspector/front-end/inspector.js index aaa3a68..cd1a808 100644 --- a/Source/WebCore/inspector/front-end/inspector.js +++ b/Source/WebCore/inspector/front-end/inspector.js @@ -436,6 +436,11 @@ var WebInspector = { return WebInspector.UIString(WebInspector.useLowerCaseMenuTitles() ? "Open link in new tab" : "Open Link in New Tab"); }, + openInNetworkPanelLabel: function() + { + return WebInspector.UIString(WebInspector.useLowerCaseMenuTitles() ? "Open in network panel" : "Open in Network Panel"); + }, + copyLinkAddressLabel: function() { return WebInspector.UIString(WebInspector.useLowerCaseMenuTitles() ? "Copy link address" : "Copy Link Address"); @@ -719,6 +724,12 @@ WebInspector.openResource = function(resourceURL, inResourcesPanel) PageAgent.open(resourceURL, true); } +WebInspector.openRequestInNetworkPanel = function(resource) +{ + WebInspector.showPanel("network"); + WebInspector.panels.network.revealAndHighlightResource(resource); +} + WebInspector._registerShortcuts = function() { var shortcut = WebInspector.KeyboardShortcut; -- 2.7.4