From 213e06f078ee87a8e610817aefd880ee5b537b24 Mon Sep 17 00:00:00 2001 From: Egor Bogatov Date: Fri, 5 Jul 2019 18:02:44 +0300 Subject: [PATCH] [netcore] CI work, add rsp for Windows (mono/mono#15549) Commit migrated from https://github.com/mono/mono/commit/3a7afab91c2a7feb210aedc1053bbc44f80f6d25 --- src/mono/netcore/CoreFX.issues.rsp | 21 ++------- src/mono/netcore/CoreFX.issues_linux.rsp | 9 ++++ src/mono/netcore/CoreFX.issues_windows.rsp | 74 ++++++++++++++++++++++++++++++ src/mono/netcore/Makefile | 4 +- 4 files changed, 89 insertions(+), 19 deletions(-) create mode 100644 src/mono/netcore/CoreFX.issues_windows.rsp diff --git a/src/mono/netcore/CoreFX.issues.rsp b/src/mono/netcore/CoreFX.issues.rsp index 982c3c8..ef16de4 100644 --- a/src/mono/netcore/CoreFX.issues.rsp +++ b/src/mono/netcore/CoreFX.issues.rsp @@ -16,14 +16,6 @@ -nomethod Microsoft.VisualBasic.ApplicationServices.Tests.AssemblyInfoTests.LoadedAssemblies #################################################################### -## System.Buffers.Tests -#################################################################### - -# CoreCLR specific test -# https://github.com/mono/mono/blob/cc5886e3d54a7fae15bfd8bda1e8781fcbf2be25/netcore/System.Private.CoreLib/shared/System/Buffers/TlsOverPerCoreLockedStacksArrayPool.cs#L319-L325 --nomethod System.Buffers.ArrayPool.Tests.CollectionTests.PollingEventFires - -#################################################################### ## System.CodeDom.Tests #################################################################### @@ -221,11 +213,6 @@ ## System.Memory.Tests #################################################################### -# CoreCLR specific test -# https://github.com/mono/mono/blob/18f0bf055eb2bfa8981062bdad3af2fb4bbc9be4/netcore/System.Private.CoreLib/shared/System/String.cs#L790-L800 -# https://github.com/mono/mono/blob/18f0bf055eb2bfa8981062bdad3af2fb4bbc9be4/netcore/System.Private.CoreLib/shared/System/String.cs#L811-L821 --nomethod System.Tests.StringTests.NormalizationTest - # System.BadImageFormatException : Cannot box IsByRefLike type 'System.Span`1' # https://github.com/mono/mono/issues/14959 -nomethod System.SpanTests.SpanTests.MemoryMarshal_GenericStaticReturningSpan @@ -295,10 +282,6 @@ ## System.Net.Sockets.Tests #################################################################### -# Test does not run -> Precise GC not supported. -# https://github.com/mono/mono/issues/15009 --nomethod System.Net.Sockets.Tests.UdpClientTest.Finalize_NoExceptionsThrown - # TODO: Hangs and fails. # https://github.com/mono/mono/issues/15010 -nomethod System.Net.Sockets.Tests.CreateSocket.CtorAndAccept_SocketNotKeptAliveViaInheritance @@ -306,6 +289,9 @@ # flaky test -nomethod System.Net.Sockets.Tests.SocketOptionNameTest.MulticastInterface_Set_AnyInterface_Succeeds +# requires precise GC (should be ignored in corefx) +-nomethod System.Net.Sockets.Tests.DisposedSocket.NonDisposedSocket_SafeHandlesCollected + #################################################################### ## System.Reflection.Emit.ILGeneration.Tests #################################################################### @@ -1277,6 +1263,7 @@ # requires precise gc (should be ignored in corefx) -nomethod System.IO.Tests.FileStream_Dispose.FinalizeFlushesWriteBuffer +-nomethod System.IO.Tests.FileStream_Dispose.Dispose_CallsVirtualDispose_TrueArg -nomethod System.IO.Tests.File_Move_Tests.File_Move_From_Unwatched_To_Watched diff --git a/src/mono/netcore/CoreFX.issues_linux.rsp b/src/mono/netcore/CoreFX.issues_linux.rsp index e20a78d..bdbe8b9 100644 --- a/src/mono/netcore/CoreFX.issues_linux.rsp +++ b/src/mono/netcore/CoreFX.issues_linux.rsp @@ -20,3 +20,12 @@ -nomethod System.Tests.WeakReferenceTests.Generic -nomethod System.Reflection.Tests.AssemblyTests.CreateInstance + +# StackOverflow somewhere here +-nonamespace System.Threading.Tasks.Tests + +# NRE in SafeHandle.Dispose +-noclass SafeWaitHandleExtensions_4000_Tests +-noclass SafeWaitHandle_4000_Tests +-noclass SafeHandle_4000_Tests +-noclass CriticalHandle_4000_Tests \ No newline at end of file diff --git a/src/mono/netcore/CoreFX.issues_windows.rsp b/src/mono/netcore/CoreFX.issues_windows.rsp new file mode 100644 index 0000000..484dd36 --- /dev/null +++ b/src/mono/netcore/CoreFX.issues_windows.rsp @@ -0,0 +1,74 @@ +# requires precise gc +-nomethod System.Tests.GCTests.ReRegisterForFinalize +-nomethod System.Runtime.CompilerServices.Tests.ConditionalWeakTableTests.GetEnumerator_CollectedItemsNotEnumerated +-nomethod System.Runtime.CompilerServices.Tests.ConditionalWeakTableTests.AddRemove_DropValue +-nomethod System.Tests.WeakReferenceTests.NonGeneric +-nomethod System.Tests.WeakReferenceTests.Generic + +# GCSettings.SetGCLatencyMode is not implemented +-nomethod System.Tests.GCTests.LatencyRoundtrips_LowLatency + +# Type.GetTypeFromCLSID is not implemented +-nomethod System.Tests.TypeTestsNetcore.* + +# these math functions should be portable, e.g. see HAVE_COMPATIBLE_EXP in coreclr +-nomethod System.Tests.MathFTests.Acosh +-nomethod System.Tests.MathFTests.Atanh +-nomethod System.Tests.MathFTests.Asinh +-nomethod System.Tests.MathTests.Acosh +-nomethod System.Tests.MathTests.Atanh +-nomethod System.Tests.MathTests.Asinh +-nomethod Microsoft.VisualBasic.Tests.ConversionTests.Val + +# segfault +-nomethod Microsoft.VisualBasic.Tests.FileSystemTests.Input_Object_Write + +# TODO: investigate (too many failures or stuck) +-nomethod System.Threading.Tests.WaitHandleTests.SignalAndWait +-nomethod System.Threading.Tests.WaitHandleTests.WaitAll_SameNames +-nomethod System.Tests.ActivatorTests.TestingCreateInstanceObjectHandleFullSignatureWinRT +-nonamespace System.IO.Pipes.Tests +-nonamespace System.IO.Tests +-nonamespace System.Net +-nonamespace System.Threading.Tasks.Dataflow.Tests +-nonamespace System.Security.Cryptography.Pkcs +-nonamespace System.Runtime.InteropServices.WindowsRuntime +-nonamespace System.Management.Tests +-nonamespace System.Data.SqlClient.Tests +-nonamespace System.Threading.Overlapped.Tests +-nonamespace System.ComponentModel.Composition +-nonamespace BasicEventSourceTests +-nonamespace System.ComponentModel.TypeConverterTests + +-nomethod System.Diagnostics.Tests.CounterSampleTests.* +-nomethod Tests.Integration.DiscoveryTests.DiscoverAddinsWithCombinedCustomExportAndMetadataAttribute +-nomethod WindowAndCursorProps.* +-nomethod System.Diagnostics.Tests.ProcessStartInfoTests.StartInfo_BadVerb +-nomethod System.Diagnostics.Tests.ProcessStartInfoTests.StartInfo_BadExe +-nomethod System.Diagnostics.Tests.ProcessTests.ProcessStart_UseShellExecute_Executes +-nomethod System.Diagnostics.Tests.ProcessTests.ProcessStart_UseShellExecute_WorkingDirectory +-nomethod System.Diagnostics.TraceSourceTests.SwitchClassTests.PruneTest +-nomethod System.DirectoryServices.AccountManagement.Tests.PrincipalContextTests.Ctor_ContextType +-nomethod System.DirectoryServices.AccountManagement.Tests.PrincipalContextTests.ValidateCredentials_Invoke_ReturnsExpected +-nomethod System.DirectoryServices.AccountManagement.Tests.ComputerPrincipalTest.Ctor_MachineContext_NoException +-nomethod System.DirectoryServices.ActiveDirectory.Tests.DomainControllerTests.GetDomainController_InvalidIPV6 +-nomethod System.DirectoryServices.Tests.DirectoryEntryTests.DeleteTree_NoObject_ThrowsCOMException +-nomethod System.DirectoryServices.ActiveDirectory.Tests.ForestTests.GetForest_NonNullNameAndNotRootedDomain_ThrowsActiveDirectoryObjectNotFoundException +-nomethod System.Reflection.Internal.Tests.AbstractMemoryBlockTests.FileStream +-nomethod System.Reflection.Internal.Tests.AbstractMemoryBlockTests.FileStreamUnix +-nomethod System.Reflection.Tests.MemberInfoNetCoreAppTests.* +-nomethod System.Reflection.Tests.AssemblyNameTests.GetAssemblyName_LockedFile +-nomethod System.Resources.Extensions.Tests.PreserializedResourceWriterTests.* +-nomethod System.Resources.Tests.ResourceManagerTests.* +-nomethod MonoTests.System.Runtime.Caching.HostFileChangeMonitorTest.* +-nomethod SafeHandle_4000_Tests.SafeHandle_DangerousReleasePreservesLastError +-nomethod System.Security.Cryptography.X509Certificates.Tests.FindTests.* +-nomethod OverlappedTests.PackPosTest1 +-nomethod OverlappedTests.PackPosTest +-nomethod ThreadPoolBoundHandleTests.* +-nomethod System.Threading.Tests.EventWaitHandleTests.* +-nomethod System.Threading.Tests.MutexTests.* +-nomethod System.Threading.Tests.SemaphoreTests.* +-nomethod System.Threading.Threads.Tests.ThreadTests.* +-nomethod System.ComponentModel.TypeConverterTests +-nomethod System.Xml.Tests.CTransformResolverTest.TC_AbsolutePath_Transform \ No newline at end of file diff --git a/src/mono/netcore/Makefile b/src/mono/netcore/Makefile index 3e1dc33..655767d 100644 --- a/src/mono/netcore/Makefile +++ b/src/mono/netcore/Makefile @@ -22,7 +22,7 @@ PLATFORM_AOT_SUFFIX := .dll PLATFORM_AOT_PREFIX := NETCORESDK_EXT = zip UNZIPCMD = python -c "import zipfile,sys; zipfile.ZipFile(sys.argv[1], 'r').extractall()" -XUNIT_FLAGS = -notrait category=nonwindowstests +XUNIT_FLAGS = -notrait category=nonwindowstests @../../../../CoreFX.issues_windows.rsp TESTS_PLATFORM = Windows_NT.x64 ON_RUNTIME_EXTRACT = chmod -R 755 {host,shared,./dotnet} DOTNET := $(shell powershell -ExecutionPolicy Bypass -Command "./init-tools.ps1")/dotnet.exe @@ -149,7 +149,7 @@ corefx/.stamp-dl-corefx-tests-$(NETCORETESTS_VERSION): run-tests-corefx: update-tests-corefx for testdir in corefx/tests/extracted/*; do \ - $(MAKE) run-tests-corefx-$$(basename $${testdir}); \ + $(MAKE) run-tests-corefx-$$(basename $${testdir}) || true; \ done; \ $(MAKE) xunit-summary -- 2.7.4