From 20ec186dac622446c5f30ce63d44d14dda1f8749 Mon Sep 17 00:00:00 2001 From: Yongjoo Ahn Date: Tue, 11 Feb 2020 15:39:32 +0900 Subject: [PATCH] fix coverity CID: 1123841, 1123966 1123841 - check the return value of sensor_listener_start 1123966 - g_free the newly allocated memory Signed-off-by: Yongjoo Ahn --- ext/nnstreamer/tensor_source/tensor_src_tizensensor.c | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/ext/nnstreamer/tensor_source/tensor_src_tizensensor.c b/ext/nnstreamer/tensor_source/tensor_src_tizensensor.c index 3da560b..b6eb10e 100644 --- a/ext/nnstreamer/tensor_source/tensor_src_tizensensor.c +++ b/ext/nnstreamer/tensor_source/tensor_src_tizensensor.c @@ -590,6 +590,7 @@ _ts_configure_handle (GstTensorSrcTIZENSENSOR * self) "The requested sensor sequence %d for sensor %d is not available. The max-sequence is used instead", self->sequence, self->type); self->sequence = 0; + g_free (list); return -EINVAL; } @@ -867,8 +868,16 @@ gst_tensor_src_tizensensor_start (GstBaseSrc * src) gst_base_src_set_dynamic_size (src, FALSE); /* 3. Fire it up! */ + if (sensor_listener_start (self->listener) != 0) { + /* Failed to start listener. Clean this up */ + ret = _ts_clean_up_handle (self); + if (ret) { + GST_ERROR_OBJECT (self, "_ts_clean_up_handle () returns %d", ret); + } + retval = FALSE; + goto exit; + } self->running = TRUE; - sensor_listener_start (self->listener); /** complete the start of the base src */ gst_base_src_start_complete (src, GST_FLOW_OK); -- 2.7.4