From 20e61971e5db3fe9f0c7b7d38841fa43f68fddd0 Mon Sep 17 00:00:00 2001 From: =?utf8?q?Mika=20Isoj=C3=A4rvi?= Date: Mon, 16 Mar 2015 17:24:42 -0700 Subject: [PATCH] Remove incomplete integer texture gather tests. Sampling floating point values from incomplete texture always produces (0, 0, 0, 1), but sampling integer or unsigned integer values return undefined values. Bug: 19733810 Change-Id: I32e8c6dcdc9ed7fd0a875857174d91fc605d958a --- modules/gles31/functional/es31fTextureGatherTests.cpp | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/modules/gles31/functional/es31fTextureGatherTests.cpp b/modules/gles31/functional/es31fTextureGatherTests.cpp index 42316ac..f5a5540 100644 --- a/modules/gles31/functional/es31fTextureGatherTests.cpp +++ b/modules/gles31/functional/es31fTextureGatherTests.cpp @@ -2267,7 +2267,9 @@ void TextureGatherTests::init (void) } } - if (!isDepthFormat(format)) // What shadow textures should return for incomplete textures is unclear. + // What shadow textures should return for incomplete textures is unclear. + // Integer and unsigned integer lookups from incomplete textures return undefined values. + if (!isDepthFormat(format) && !isSIntFormatType(format.type) && !isUIntFormatType(format.type)) { TestCaseGroup* const incompleteGroup = new TestCaseGroup(m_context, "incomplete", "Test that textureGather* takes components from (0,0,0,1) for incomplete textures"); formatGroup->addChild(incompleteGroup); -- 2.7.4