From 209ab6d8835cd88320ceb814893759cfbda91d15 Mon Sep 17 00:00:00 2001 From: Hans Wennborg Date: Wed, 29 Apr 2020 15:12:43 +0200 Subject: [PATCH] Revert 6654719 "[CMake] Fix logic error: NOT LIBCLANG_BUILD_STATIC does not imply PIC" It broke building libclang.dll in Windows builds configured with LLVM_ENABLE_PIC=OFF. See discussion on the cfe-commits thread. --- clang/tools/libclang/CMakeLists.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/clang/tools/libclang/CMakeLists.txt b/clang/tools/libclang/CMakeLists.txt index 9368501..bb2b14c 100644 --- a/clang/tools/libclang/CMakeLists.txt +++ b/clang/tools/libclang/CMakeLists.txt @@ -77,7 +77,7 @@ if(MSVC) set(LLVM_EXPORTED_SYMBOL_FILE) endif() -if(LLVM_ENABLE_PIC) +if(LLVM_ENABLE_PIC OR NOT LIBCLANG_BUILD_STATIC) set(ENABLE_SHARED SHARED) endif() -- 2.7.4