From 205fc02b50787b862f3fa66e0c1a89841876d676 Mon Sep 17 00:00:00 2001 From: Steve Chamberlain Date: Sat, 30 Jul 1994 05:04:03 +0000 Subject: [PATCH] * remote.c (read_frame): Split readchar/checksum calculation into two parts since evaluation order is undefined. --- gdb/ChangeLog | 5 +++++ gdb/remote.c | 4 ++-- 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 1c3a954..5112690 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,8 @@ +Fri Jul 29 21:56:23 1994 Steve Chamberlain (sac@jonny.cygnus.com) + + * remote.c (read_frame): Split readchar/checksum calculation into + two parts since evaluation order is undefined. + Fri Jul 29 13:46:08 1994 Fred Fish (fnf@cygnus.com) From Kevin A. Buettner (kev@cujo.geg.mot.com). diff --git a/gdb/remote.c b/gdb/remote.c index d5b677e..828b062 100644 --- a/gdb/remote.c +++ b/gdb/remote.c @@ -1231,8 +1231,8 @@ read_frame (buf) *bp = '\000'; - pktcsum = fromhex (readchar (remote_timeout)) << 4 - | fromhex (readchar (remote_timeout)); + pktcsum = fromhex (readchar (remote_timeout)) << 4; + pktcsum |= fromhex (readchar (remote_timeout)); if (csum == pktcsum) return 1; -- 2.7.4