From 204f1ce879753dc3fe5b0f86222d07d000e9fb9b Mon Sep 17 00:00:00 2001 From: "mstarzinger@chromium.org" Date: Fri, 1 Aug 2014 10:47:01 +0000 Subject: [PATCH] Extend TF test coverage to supported targets. R=danno@google.com, titzer@chromium.org TEST=all Review URL: https://codereview.chromium.org/432313002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22787 ce2b1a6d-e550-0410-aec6-3dcde31c8c00 --- src/compiler.cc | 8 ++++++-- src/compiler/pipeline.cc | 2 +- tools/run-tests.py | 2 +- 3 files changed, 8 insertions(+), 4 deletions(-) diff --git a/src/compiler.cc b/src/compiler.cc index 962e792..6d22db2 100644 --- a/src/compiler.cc +++ b/src/compiler.cc @@ -413,10 +413,14 @@ OptimizedCompileJob::Status OptimizedCompileJob::CreateGraph() { info()->function()->dont_optimize_reason() != kTryCatchStatement && info()->function()->dont_optimize_reason() != kTryFinallyStatement && // TODO(turbofan): Make OSR work and remove this bailout. - !info()->is_osr()) { + !info()->is_osr() && + // TODO(mstarzinger): Extend test coverage to unsupported targets. + compiler::Pipeline::SupportedTarget()) { compiler::Pipeline pipeline(info()); pipeline.GenerateCode(); - return SetLastStatus(SUCCEEDED); + if (!info()->code().is_null()) { + return SetLastStatus(SUCCEEDED); + } } if (FLAG_trace_hydrogen) { diff --git a/src/compiler/pipeline.cc b/src/compiler/pipeline.cc index ef071bb..7a04608 100644 --- a/src/compiler/pipeline.cc +++ b/src/compiler/pipeline.cc @@ -170,7 +170,7 @@ Handle Pipeline::GenerateCode() { } } - { + if (SupportedTarget()) { // Lower any remaining generic JSOperators. PhaseStats lowering_stats(info(), PhaseStats::CREATE_GRAPH, "generic lowering"); diff --git a/tools/run-tests.py b/tools/run-tests.py index cbc6116..5484b3f 100755 --- a/tools/run-tests.py +++ b/tools/run-tests.py @@ -62,7 +62,7 @@ VARIANT_FLAGS = { "turbofan": ["--turbo-filter=*", "--always-opt"], "nocrankshaft": ["--nocrankshaft"]} -VARIANTS = ["default", "stress", "nocrankshaft"] +VARIANTS = ["default", "stress", "turbofan", "nocrankshaft"] MODE_FLAGS = { "debug" : ["--nohard-abort", "--nodead-code-elimination", -- 2.7.4