From 204ade4102c7959cc56e03f163ad7473c94a0b38 Mon Sep 17 00:00:00 2001 From: Evgeny Stupachenko Date: Wed, 7 Mar 2018 02:17:08 +0000 Subject: [PATCH] Add early exit on reassociation of 0 expression. Summary: Before the patch a try to reassociate ((v * 16) * 0) * 1 fall into infinite loop Reviewers: pankajchawla Differential Revision: http://reviews.llvm.org/D41467 From: Evgeny Stupachenko llvm-svn: 326861 --- llvm/lib/Transforms/Scalar/NaryReassociate.cpp | 3 +++ llvm/test/Transforms/NaryReassociate/pr35710.ll | 19 +++++++++++++++++++ 2 files changed, 22 insertions(+) create mode 100644 llvm/test/Transforms/NaryReassociate/pr35710.ll diff --git a/llvm/lib/Transforms/Scalar/NaryReassociate.cpp b/llvm/lib/Transforms/Scalar/NaryReassociate.cpp index b026c8d..243d7fe 100644 --- a/llvm/lib/Transforms/Scalar/NaryReassociate.cpp +++ b/llvm/lib/Transforms/Scalar/NaryReassociate.cpp @@ -429,6 +429,9 @@ NaryReassociatePass::tryReassociateGEPAtIndex(GetElementPtrInst *GEP, Instruction *NaryReassociatePass::tryReassociateBinaryOp(BinaryOperator *I) { Value *LHS = I->getOperand(0), *RHS = I->getOperand(1); + // There is no need to reassociate 0. + if (SE->getSCEV(I)->isZero()) + return nullptr; if (auto *NewI = tryReassociateBinaryOp(LHS, RHS, I)) return NewI; if (auto *NewI = tryReassociateBinaryOp(RHS, LHS, I)) diff --git a/llvm/test/Transforms/NaryReassociate/pr35710.ll b/llvm/test/Transforms/NaryReassociate/pr35710.ll new file mode 100644 index 0000000..f46dd27 --- /dev/null +++ b/llvm/test/Transforms/NaryReassociate/pr35710.ll @@ -0,0 +1,19 @@ +; NOTE: Assertions have been autogenerated by utils/update_test_checks.py +; RUN: opt < %s -nary-reassociate -S | FileCheck %s + +; The test check that compilation does not fall into infinite loop. + +define i8 @foo(i8 %v) local_unnamed_addr #0 { +; CHECK-LABEL: @foo( +; CHECK-NEXT: region.0: +; CHECK-NEXT: [[TMP0:%.*]] = mul nsw i8 16, [[V:%.*]] +; CHECK-NEXT: [[TMP1:%.*]] = mul nsw i8 0, [[TMP0]] +; CHECK-NEXT: [[TMP2:%.*]] = mul nsw i8 1, [[TMP1]] +; CHECK-NEXT: ret i8 [[TMP2]] +; +region.0: + %0 = mul nsw i8 16, %v + %1 = mul nsw i8 0, %0 + %2 = mul nsw i8 1, %1 + ret i8 %2 +} -- 2.7.4