From 203916231d946794d9cbba43de9c484b451ce8e7 Mon Sep 17 00:00:00 2001 From: Ahreum Jeong Date: Mon, 4 Sep 2017 20:06:25 +0900 Subject: [PATCH] Fix wrong coding rules in os, framework folder os/include/net/lwip/lwipopts.h:400: ERROR: [IDT_M_TAB] please, no space before tabs os/include/net/lwip/lwipopts.h:404: ERROR: [IDT_M_TAB] please, no space before tabs os/include/tinyara/scsi.h:441: ERROR: [IDT_M_TAB] code indent should use tabs where possible os/include/tinyara/scsi.h:445: ERROR: [IDT_M_TAB] code indent should use tabs where possible os/include/tinyara/fs/ioctl.h:298: ERROR: [SPC_M_OPR] spaces required around that '==' (ctx:WxV) framework/src/mqtt/config.h:45: ERROR: [SPC_M_OPR] space required after that ',' (ctx:VxV) --- framework/src/mqtt/config.h | 2 +- os/arch/arm/src/s5j/s5j_boot.c | 3 ++- os/include/net/lwip/lwipopts.h | 4 ++-- os/include/tinyara/fs/ioctl.h | 2 +- os/include/tinyara/scsi.h | 4 ++-- 5 files changed, 8 insertions(+), 7 deletions(-) diff --git a/framework/src/mqtt/config.h b/framework/src/mqtt/config.h index 3c57f27..32797de 100644 --- a/framework/src/mqtt/config.h +++ b/framework/src/mqtt/config.h @@ -42,7 +42,7 @@ #endif #define uthash_malloc(sz) _mosquitto_malloc(sz) -#define uthash_free(ptr,sz) _mosquitto_free(ptr) +#define uthash_free(ptr, sz) _mosquitto_free(ptr) #ifndef EPROTO # define EPROTO ECONNABORTED diff --git a/os/arch/arm/src/s5j/s5j_boot.c b/os/arch/arm/src/s5j/s5j_boot.c index b2f3ca1..2652659 100644 --- a/os/arch/arm/src/s5j/s5j_boot.c +++ b/os/arch/arm/src/s5j/s5j_boot.c @@ -109,7 +109,8 @@ static inline void up_idlestack_color(void *pv, unsigned int nbytes) "\tbne 1b\n" /* Bottom of the loop */ "2:\n" "\tmov r14, #0\n" /* LR = return address (none) */ "\tb os_start\n" /* Branch to os_start */ - :: "r"(r0), "r"(r1) + : /* No Output */ + : "r"(r0), "r"(r1) ); __builtin_unreachable(); diff --git a/os/include/net/lwip/lwipopts.h b/os/include/net/lwip/lwipopts.h index d0b1907..7163ce4 100644 --- a/os/include/net/lwip/lwipopts.h +++ b/os/include/net/lwip/lwipopts.h @@ -397,11 +397,11 @@ #endif */ #ifdef CONFIG_NET_MEMP_NUM_TCPIP_MSG_API -#define MEMP_NUM_TCPIP_MSG_API CONFIG_NET_MEMP_NUM_TCPIP_MSG_API +#define MEMP_NUM_TCPIP_MSG_API CONFIG_NET_MEMP_NUM_TCPIP_MSG_API #endif #ifdef CONFIG_NET_MEMP_NUM_TCPIP_MSG_INPKT -#define MEMP_NUM_TCPIP_MSG_INPKT CONFIG_NET_MEMP_NUM_TCPIP_MSG_INPKT +#define MEMP_NUM_TCPIP_MSG_INPKT CONFIG_NET_MEMP_NUM_TCPIP_MSG_INPKT #endif #ifdef CONFIG_NET_MEMP_NUM_SNMP_NODE diff --git a/os/include/tinyara/fs/ioctl.h b/os/include/tinyara/fs/ioctl.h index d53825a..19ac985 100644 --- a/os/include/tinyara/fs/ioctl.h +++ b/os/include/tinyara/fs/ioctl.h @@ -295,7 +295,7 @@ /* Audio driver ioctl definitions *************************************/ /* (see tinyara/audio/audio.h) */ -#define _AUDIOIOCVALID(c) (_IOC_TYPE(c) ==_AUDIOIOCBASE) +#define _AUDIOIOCVALID(c) (_IOC_TYPE(c) == _AUDIOIOCBASE) #define _AUDIOIOC(nr) _IOC(_AUDIOIOCBASE, nr) /* Application Config Data driver ioctl definitions *************************/ diff --git a/os/include/tinyara/scsi.h b/os/include/tinyara/scsi.h index 609b29a..d06cd8c 100644 --- a/os/include/tinyara/scsi.h +++ b/os/include/tinyara/scsi.h @@ -438,11 +438,11 @@ /* Inquiry */ #define SCSICMD_INQUIRYFLAGS_EVPD 0x01 /* Bit 0: EVPD */ - /* Bits 5-7: Peripheral Qualifier */ + /* Bits 5-7: Peripheral Qualifier */ #define SCSIRESP_INQUIRYPQ_CONNECTED 0x00 /* 000: Device is connected */ #define SCSIRESP_INQUIRYPQ_NOTCONNECTED 0x20 /* 001: Device is NOT connected */ #define SCSIRESP_INQUIRYPQ_NOTCAPABLE 0x60 /* 011: LUN not supported */ - /* Bits 0-4: Peripheral Device */ + /* Bits 0-4: Peripheral Device */ #define SCSIRESP_INQUIRYPD_DIRECTACCESS 0x00 /* Direct-access block device */ #define SCSIRESP_INQUIRYPD_SEQUENTIALACCESS 0x01 /* Sequential-access block device */ #define SCSIRESP_INQUIRYPD_PRINTER 0x02 /* Printer device */ -- 2.7.4