From 2023d1633ea0cb6bd3075d302d9071f55d0ea793 Mon Sep 17 00:00:00 2001 From: Jukka Rissanen Date: Wed, 24 Aug 2011 17:02:05 +0300 Subject: [PATCH] connection: Service was not ref counted properly The reference counting problems were clearly seen with VPN service. --- src/connection.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/connection.c b/src/connection.c index d8d95f3..477cf84 100644 --- a/src/connection.c +++ b/src/connection.c @@ -229,6 +229,7 @@ static struct gateway_data *add_gateway(struct connman_service *service, } } + connman_service_ref(service); g_hash_table_replace(gateway_hash, service, data); return data; @@ -720,9 +721,10 @@ void __connman_connection_gateway_remove(struct connman_service *service, && do_ipv4 == TRUE) || (data->ipv6_gateway != NULL && data->ipv4_gateway == NULL && do_ipv6 == TRUE) - ) + ) { + connman_service_unref(service); g_hash_table_remove(gateway_hash, service); - else + } else DBG("Not yet removing gw ipv4 %p/%d ipv6 %p/%d", data->ipv4_gateway, do_ipv4, data->ipv6_gateway, do_ipv6); -- 2.7.4