From 1ff18f08792a9f8731fb8a58f313b515e70c874a Mon Sep 17 00:00:00 2001 From: Mike Blumenkrantz Date: Fri, 15 Jul 2022 16:35:22 -0400 Subject: [PATCH] zink: break out renderpass attachment load op calc no functional changes Reviewed-by: Dave Airlie Part-of: --- src/gallium/drivers/zink/zink_render_pass.c | 17 +++++++++++------ 1 file changed, 11 insertions(+), 6 deletions(-) diff --git a/src/gallium/drivers/zink/zink_render_pass.c b/src/gallium/drivers/zink/zink_render_pass.c index b7cec65..c574c9e 100644 --- a/src/gallium/drivers/zink/zink_render_pass.c +++ b/src/gallium/drivers/zink/zink_render_pass.c @@ -33,6 +33,16 @@ #include "util/u_string.h" #include "util/u_blitter.h" +static VkAttachmentLoadOp +get_rt_loadop(const struct zink_rt_attrib *rt, bool clear) +{ + return clear ? VK_ATTACHMENT_LOAD_OP_CLEAR : + /* TODO: need replicate EXT */ + //rt->resolve || rt->invalid ? + rt->invalid ? + VK_ATTACHMENT_LOAD_OP_DONT_CARE : + VK_ATTACHMENT_LOAD_OP_LOAD; +} static VkRenderPass create_render_pass2(struct zink_screen *screen, struct zink_render_pass_state *state, struct zink_render_pass_pipeline_state *pstate) @@ -58,12 +68,7 @@ create_render_pass2(struct zink_screen *screen, struct zink_render_pass_state *s attachments[i].flags = 0; pstate->attachments[i].format = attachments[i].format = rt->format; pstate->attachments[i].samples = attachments[i].samples = rt->samples; - attachments[i].loadOp = rt->clear_color ? VK_ATTACHMENT_LOAD_OP_CLEAR : - /* TODO: need replicate EXT */ - //rt->resolve || rt->invalid ? - rt->invalid ? - VK_ATTACHMENT_LOAD_OP_DONT_CARE : - VK_ATTACHMENT_LOAD_OP_LOAD; + attachments[i].loadOp = get_rt_loadop(rt, rt->clear_color); /* TODO: need replicate EXT */ //attachments[i].storeOp = rt->resolve ? VK_ATTACHMENT_STORE_OP_DONT_CARE : VK_ATTACHMENT_STORE_OP_STORE; -- 2.7.4