From 1faab08daf19e4769865936614a8a7bef1d72dd6 Mon Sep 17 00:00:00 2001 From: Martin Jambor Date: Wed, 15 Sep 2010 17:59:27 +0200 Subject: [PATCH] re PR middle-end/45644 (450.soplex in SPEC CPU 2006 is miscompiled) 2010-09-15 Martin Jambor PR middle-end/45644 * tree-sra.c (create_access): Check for bit-fields directly. * testsuite/gcc.dg/ipa/pr45644.c: New test. From-SVN: r164313 --- gcc/ChangeLog | 5 +++++ gcc/testsuite/ChangeLog | 5 +++++ gcc/testsuite/gcc.dg/ipa/pr45644.c | 35 +++++++++++++++++++++++++++++++++++ gcc/tree-sra.c | 7 ++++--- 4 files changed, 49 insertions(+), 3 deletions(-) create mode 100644 gcc/testsuite/gcc.dg/ipa/pr45644.c diff --git a/gcc/ChangeLog b/gcc/ChangeLog index 09da047..20a608f 100644 --- a/gcc/ChangeLog +++ b/gcc/ChangeLog @@ -1,3 +1,8 @@ +2010-09-15 Martin Jambor + + PR middle-end/45644 + * tree-sra.c (create_access): Check for bit-fields directly. + 2010-09-15 Jakub Jelinek PR tree-optimization/45633 diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog index cde5eea..d03b017 100644 --- a/gcc/testsuite/ChangeLog +++ b/gcc/testsuite/ChangeLog @@ -1,3 +1,8 @@ +2010-09-15 Martin Jambor + + PR middle-end/45644 + * gcc.dg/ipa/pr45644.c: New test. + 2010-09-15 Jakub Jelinek PR tree-optimization/45633 diff --git a/gcc/testsuite/gcc.dg/ipa/pr45644.c b/gcc/testsuite/gcc.dg/ipa/pr45644.c new file mode 100644 index 0000000..3f61b8b --- /dev/null +++ b/gcc/testsuite/gcc.dg/ipa/pr45644.c @@ -0,0 +1,35 @@ +/* Verify that we do not IPA-SRA bitfields. */ +/* { dg-do run } */ +/* { dg-options "-O2" } */ + +extern void abort (void); + +struct S +{ + int j : 8; + int i : 24; + int l; +}; + +static int __attribute__((noinline)) foo (struct S *s) +{ + int z = s->i; + if (z != 777) + abort (); + return 0; +} + +int __attribute__((noinline)) bar (struct S *s) +{ + return foo (s); +} + +int main (int argc, char *argv[]) +{ + struct S s; + s.j = 5; + s.i = 777; + s.l = -1; + + return bar (&s); +} diff --git a/gcc/tree-sra.c b/gcc/tree-sra.c index e3007ee..0127b82 100644 --- a/gcc/tree-sra.c +++ b/gcc/tree-sra.c @@ -774,12 +774,13 @@ create_access (tree expr, gimple stmt, bool write) disqualify_candidate (base, "Encountered a variable sized access."); return NULL; } - if ((offset % BITS_PER_UNIT) != 0 || (size % BITS_PER_UNIT) != 0) + if (TREE_CODE (expr) == COMPONENT_REF + && DECL_BIT_FIELD (TREE_OPERAND (expr, 1))) { - disqualify_candidate (base, - "Encountered an acces not aligned to a byte."); + disqualify_candidate (base, "Encountered a bit-field access."); return NULL; } + gcc_checking_assert ((offset % BITS_PER_UNIT) == 0); if (ptr) mark_parm_dereference (base, offset + size, stmt); -- 2.7.4