From 1f3680c5b7efefb69d95fc95a6f7953e36b4f9ee Mon Sep 17 00:00:00 2001 From: salimfadhley Date: Sat, 26 Oct 2013 09:33:19 +0100 Subject: [PATCH] Some tidy-ups --- doc/source/rules_for_contributors.rst | 2 ++ jenkinsapi/views.py | 2 -- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/doc/source/rules_for_contributors.rst b/doc/source/rules_for_contributors.rst index ce49336..33edcb6 100644 --- a/doc/source/rules_for_contributors.rst +++ b/doc/source/rules_for_contributors.rst @@ -19,6 +19,8 @@ You might want to follow a typical test driven development cycle: http://en.wiki Put simply: Write your tests first and only implement features required to make your tests pass. Do not let your implementation get ahead of your tests. +Features implemented without tests will be removed. Unmaintained features (which break because of changes in Jenkins) will also be removed. + Check the CI status before comitting ------------------------------------ diff --git a/jenkinsapi/views.py b/jenkinsapi/views.py index 6ea043a..f48eb6d 100644 --- a/jenkinsapi/views.py +++ b/jenkinsapi/views.py @@ -13,8 +13,6 @@ class Views(object): """ An abstraction on a Jenkins object's views """ - - # TODO @lechat 20130702: Add check that plugin for view actually exists in Jenkins LIST_VIEW = 'hudson.model.ListView' NESTED_VIEW = 'hudson.plugins.nested_view.NestedView' MY_VIEW = 'hudson.model.MyView' -- 2.7.4