From 1eb8220aff18a095c180efb0f44e452eeca5f643 Mon Sep 17 00:00:00 2001 From: Eric Fiselier Date: Wed, 19 Nov 2014 05:49:03 +0000 Subject: [PATCH] Overhaul and separate nullptr_t tests to pass with C++03. The standard requires that nullptr_t can be reinterpret_cast to an integral type at least the size of nullptr_t. There is no way to emulate this conversion in the C++03 nullptr_t implementation. The test for this conversion has been moved to a new test and marked XFAIL with c++03. This recommits what was originally r222296. llvm-svn: 222318 --- .../support.types/nullptr_t.pass.cpp | 88 +++++++++++++--------- .../support.types/nullptr_t_integral_cast.fail.cpp | 17 +++++ .../support.types/nullptr_t_integral_cast.pass.cpp | 24 ++++++ 3 files changed, 95 insertions(+), 34 deletions(-) create mode 100644 libcxx/test/language.support/support.types/nullptr_t_integral_cast.fail.cpp create mode 100644 libcxx/test/language.support/support.types/nullptr_t_integral_cast.pass.cpp diff --git a/libcxx/test/language.support/support.types/nullptr_t.pass.cpp b/libcxx/test/language.support/support.types/nullptr_t.pass.cpp index 6c15fef..4d7c8b0 100644 --- a/libcxx/test/language.support/support.types/nullptr_t.pass.cpp +++ b/libcxx/test/language.support/support.types/nullptr_t.pass.cpp @@ -18,42 +18,62 @@ struct A A(std::nullptr_t) {} }; +template +void test_conversions() +{ + { + T p = 0; + assert(p == nullptr); + } + { + T p = nullptr; + assert(p == nullptr); + assert(nullptr == p); + assert(!(p != nullptr)); + assert(!(nullptr != p)); + } +} + +template +void test_comparisons() +{ + T p = nullptr; + assert(p == nullptr); + assert(p <= nullptr); + assert(p >= nullptr); + assert(!(p != nullptr)); + assert(!(p < nullptr)); + assert(!(p > nullptr)); + assert(nullptr == p); + assert(nullptr <= p); + assert(nullptr >= p); + assert(!(nullptr != p)); + assert(!(nullptr < p)); + assert(!(nullptr > p)); +} + + int main() { static_assert(sizeof(std::nullptr_t) == sizeof(void*), "sizeof(std::nullptr_t) == sizeof(void*)"); - A* p = 0; - assert(p == nullptr); - void (A::*pmf)() = 0; -#ifdef __clang__ - // GCC 4.2 can't handle this - assert(pmf == nullptr); -#endif - int A::*pmd = 0; - assert(pmd == nullptr); - A a1(nullptr); - A a2(0); - bool b = nullptr; - assert(!b); - assert(nullptr == nullptr); - assert(nullptr <= nullptr); - assert(nullptr >= nullptr); - assert(!(nullptr != nullptr)); - assert(!(nullptr < nullptr)); - assert(!(nullptr > nullptr)); - A* a = nullptr; - assert(a == nullptr); - assert(a <= nullptr); - assert(a >= nullptr); - assert(!(a != nullptr)); - assert(!(a < nullptr)); - assert(!(a > nullptr)); - assert(nullptr == a); - assert(nullptr <= a); - assert(nullptr >= a); - assert(!(nullptr != a)); - assert(!(nullptr < a)); - assert(!(nullptr > a)); - std::ptrdiff_t i = reinterpret_cast(nullptr); - assert(i == 0); + + { + test_conversions(); + test_conversions(); + test_conversions(); + test_conversions(); + test_conversions(); + test_conversions(); + } + { + test_comparisons(); + test_comparisons(); + test_comparisons(); + test_comparisons(); + } + { + bool b = nullptr; + assert(!b); + } } diff --git a/libcxx/test/language.support/support.types/nullptr_t_integral_cast.fail.cpp b/libcxx/test/language.support/support.types/nullptr_t_integral_cast.fail.cpp new file mode 100644 index 0000000..92bd879 --- /dev/null +++ b/libcxx/test/language.support/support.types/nullptr_t_integral_cast.fail.cpp @@ -0,0 +1,17 @@ +//===----------------------------------------------------------------------===// +// +// The LLVM Compiler Infrastructure +// +// This file is dual licensed under the MIT and the University of Illinois Open +// Source Licenses. See LICENSE.TXT for details. +// +//===----------------------------------------------------------------------===// + +// typedef decltype(nullptr) nullptr_t; + +#include + +int main() +{ + std::ptrdiff_t i = static_cast(nullptr); +} diff --git a/libcxx/test/language.support/support.types/nullptr_t_integral_cast.pass.cpp b/libcxx/test/language.support/support.types/nullptr_t_integral_cast.pass.cpp new file mode 100644 index 0000000..34c7a93 --- /dev/null +++ b/libcxx/test/language.support/support.types/nullptr_t_integral_cast.pass.cpp @@ -0,0 +1,24 @@ +//===----------------------------------------------------------------------===// +// +// The LLVM Compiler Infrastructure +// +// This file is dual licensed under the MIT and the University of Illinois Open +// Source Licenses. See LICENSE.TXT for details. +// +//===----------------------------------------------------------------------===// + +// NOTE: nullptr_t emulation cannot handle a reinterpret_cast to an +// integral type +// XFAIL: c++98, c++03 + +// typedef decltype(nullptr) nullptr_t; + + +#include +#include + +int main() +{ + std::ptrdiff_t i = reinterpret_cast(nullptr); + assert(i == 0); +} -- 2.7.4