From 1eaa05e4bb9c3b18087f908dfb88f37514091eac Mon Sep 17 00:00:00 2001 From: Randeep Singh Date: Thu, 22 Sep 2016 11:02:02 +0530 Subject: [PATCH] [IOT-1319] Resolved potential buffer overflow case Change-Id: Ic5779a529085514a9269321c60770cd13c8fcd25 Signed-off-by: Randeep Singh Reviewed-on: https://gerrit.iotivity.org/gerrit/12137 Reviewed-by: Greg Zaverucha Tested-by: jenkins-iotivity Reviewed-by: Ashwini Kumar --- resource/csdk/security/src/policyengine.c | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/resource/csdk/security/src/policyengine.c b/resource/csdk/security/src/policyengine.c index 3dd424d..fd9f2ed 100644 --- a/resource/csdk/security/src/policyengine.c +++ b/resource/csdk/security/src/policyengine.c @@ -300,12 +300,10 @@ static void CopyParamsToContext(PEContext_t *context, memcpy(&context->subject, subjectId, sizeof(OicUuid_t)); // Copy the resource string into context. - length = strlen(resource) + 1; - if (0 < length) - { - strncpy(context->resource, resource, length); - context->resource[length - 1] = '\0'; - } + length = sizeof(context->resource) - 1; + strncpy(context->resource, resource, length); + context->resource[length] = '\0'; + // Assign the permission field. context->permission = requestedPermission; -- 2.7.4