From 1e49631ae612f18b48f2d91289754ba54531c6ef Mon Sep 17 00:00:00 2001 From: vogelheim Date: Thu, 11 Jun 2015 01:32:22 -0700 Subject: [PATCH] Revert of Re-land: Enable external startup by default on Linux. (patchset #3 id:40001 of https://codereview.chromium.org/1041683002/) Reason for revert: Revert, due to problems with stale build artefacts uncovered by this. Details: https://code.google.com/p/v8/issues/detail?id=4171 Original issue's description: > Re-land: Enable external startup by default on Linux. > > crrev.com/1016603004 should have fixed the issues that broke this last time. > > Notes: > - The current functionality is meant to stay. If you prefer the old way, > just set v8_use_external_startup_data=0. > - You might notice this if you call d8 via PATH. Either explicitly tell d8 > where your external snapshot/built-ins are, or change the build options > as above. > - This follows Chromium practice, that mostly uses this feature these days. > - Other platforms to follow later. > > BUG= > > Committed: https://crrev.com/bb9c774c164c3552b67b4f1b60809852a44f2ecd > Cr-Commit-Position: refs/heads/master@{#28858} TBR=jochen@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review URL: https://codereview.chromium.org/1177883003 Cr-Commit-Position: refs/heads/master@{#28929} --- build/standalone.gypi | 5 ----- 1 file changed, 5 deletions(-) diff --git a/build/standalone.gypi b/build/standalone.gypi index b733812..6d3d55d 100644 --- a/build/standalone.gypi +++ b/build/standalone.gypi @@ -201,11 +201,6 @@ # the C++ standard library is used. 'use_custom_libcxx%': 1, }], - ['OS=="linux" and v8_target_arch==host_arch', { - # Gradually roll out v8_use_external_startup_data. - # Should eventually be default enabled on all platforms. - 'v8_use_external_startup_data%': 1, - }], ], # Default ARM variable settings. 'arm_version%': 'default', -- 2.7.4