From 1d3f32ea79e16bdfc62d477809bd64c90ad1fce8 Mon Sep 17 00:00:00 2001 From: "ishell@chromium.org" Date: Tue, 4 Mar 2014 12:42:43 +0000 Subject: [PATCH] Don't disable hash randomization option in predictable mode. We don't need it because 1) hash randomization uses random generator whose results depend on --random-seed option which is set in predictable mode. 2) disabling hash randomization triggers assert in snapshot mode. R=svenpanne@chromium.org Review URL: https://codereview.chromium.org/171813015 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19647 ce2b1a6d-e550-0410-aec6-3dcde31c8c00 --- src/flag-definitions.h | 1 - src/v8.cc | 9 +++------ 2 files changed, 3 insertions(+), 7 deletions(-) diff --git a/src/flag-definitions.h b/src/flag-definitions.h index 3bdcc5a..c7bde36 100644 --- a/src/flag-definitions.h +++ b/src/flag-definitions.h @@ -653,7 +653,6 @@ DEFINE_bool(profile_hydrogen_code_stub_compilation, false, "Print the time it takes to lazily compile hydrogen code stubs.") DEFINE_bool(predictable, false, "enable predictable mode") -DEFINE_neg_implication(predictable, randomize_hashes) DEFINE_neg_implication(predictable, concurrent_recompilation) DEFINE_neg_implication(predictable, concurrent_osr) DEFINE_neg_implication(predictable, concurrent_sweeping) diff --git a/src/v8.cc b/src/v8.cc index a415f26..b49e0eb 100644 --- a/src/v8.cc +++ b/src/v8.cc @@ -187,12 +187,9 @@ void V8::RunMicrotasks(Isolate* isolate) { void V8::InitializeOncePerProcessImpl() { FlagList::EnforceFlagImplications(); - if (FLAG_predictable) { - if (FLAG_random_seed == 0) { - // Avoid random seeds in predictable mode. - FLAG_random_seed = 12347; - } - FLAG_hash_seed = 0; + if (FLAG_predictable && FLAG_random_seed == 0) { + // Avoid random seeds in predictable mode. + FLAG_random_seed = 12347; } if (FLAG_stress_compaction) { -- 2.7.4