From 1d299252dd52ade0e87485be29443aa69be9e910 Mon Sep 17 00:00:00 2001 From: Paul Robinson Date: Mon, 3 May 2021 11:07:12 -0700 Subject: [PATCH] [DebuggerTuning] Move a comment to a more useful place. The comment about how to make use of debugger tuning within DwarfDebug really belongs inside the DwarfDebug declaration, where it will be easier to find. --- llvm/include/llvm/Target/TargetOptions.h | 4 ---- llvm/lib/CodeGen/AsmPrinter/DwarfDebug.h | 6 +++++- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/llvm/include/llvm/Target/TargetOptions.h b/llvm/include/llvm/Target/TargetOptions.h index 5dab7de..cad356e 100644 --- a/llvm/include/llvm/Target/TargetOptions.h +++ b/llvm/include/llvm/Target/TargetOptions.h @@ -100,10 +100,6 @@ namespace llvm { /// o if the feature is useful (or not) on a particular platform, regardless /// of the debugger, that's a target decision. /// It's not impossible to see both factors in some specific case. - /// - /// The "tuning" should be used to set defaults for individual feature flags - /// in DwarfDebug; if a given feature has a more specific command-line option, - /// that option should take precedence over the tuning. enum class DebuggerKind { Default, ///< No specific tuning requested. GDB, ///< Tune debug info for gdb. diff --git a/llvm/lib/CodeGen/AsmPrinter/DwarfDebug.h b/llvm/lib/CodeGen/AsmPrinter/DwarfDebug.h index 77e4f20..6356a65 100644 --- a/llvm/lib/CodeGen/AsmPrinter/DwarfDebug.h +++ b/llvm/lib/CodeGen/AsmPrinter/DwarfDebug.h @@ -440,7 +440,11 @@ private: AccelTable AccelNamespace; AccelTable AccelTypes; - // Identify a debugger for "tuning" the debug info. + /// Identify a debugger for "tuning" the debug info. + /// + /// The "tuning" should be used to set defaults for individual feature flags + /// in DwarfDebug; if a given feature has a more specific command-line option, + /// that option should take precedence over the tuning. DebuggerKind DebuggerTuning = DebuggerKind::Default; MCDwarfDwoLineTable *getDwoLineTable(const DwarfCompileUnit &); -- 2.7.4