From 1d03a54d9460fa122f0be9bf9018b9a4358745a9 Mon Sep 17 00:00:00 2001 From: Mitch Phillips <31459023+hctim@users.noreply.github.com> Date: Mon, 7 Dec 2020 14:30:53 -0800 Subject: [PATCH] Revert "[test] Fix asan/TestCases/Linux/globals-gc-sections-lld.cpp with -fsanitize-address-globals-dead-stripping" This reverts commit 140808768d3e5c0f4e52dd42094650f5d282e34a. Reason: Broke the upstream bots - discussed offline. --- .../test/asan/TestCases/Linux/globals-gc-sections-lld.cpp | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/compiler-rt/test/asan/TestCases/Linux/globals-gc-sections-lld.cpp b/compiler-rt/test/asan/TestCases/Linux/globals-gc-sections-lld.cpp index 24dd1ae..f6edc70 100644 --- a/compiler-rt/test/asan/TestCases/Linux/globals-gc-sections-lld.cpp +++ b/compiler-rt/test/asan/TestCases/Linux/globals-gc-sections-lld.cpp @@ -1,11 +1,10 @@ -/// Without instrumenting globals, --gc-sections drops the undefined symbol. -// RUN: %clangxx_asan %s -o /dev/null -Wl,--gc-sections -fuse-ld=lld -ffunction-sections -fdata-sections -mllvm -asan-globals=0 -/// With -fsanitize-address-globals-dead-stripping and -fdata-sections, a garbage -/// collectable custom metadata section is used for instrumented globals. -// RUN: %clangxx_asan %s -o /dev/null -Wl,--gc-sections -fuse-ld=lld -ffunction-sections -fdata-sections -fsanitize-address-globals-dead-stripping +// RUN: %clangxx_asan %s -o %t -Wl,--gc-sections -fuse-ld=lld -ffunction-sections -fdata-sections -mllvm -asan-globals=0 +// RUN: %clangxx_asan %s -o %t -Wl,--gc-sections -fuse-ld=lld -ffunction-sections -fdata-sections -mllvm -asan-globals=1 -// https://github.com/google/sanitizers/issues/260 -// REQUIRES: lld-available +// https://code.google.com/p/address-sanitizer/issues/detail?id=260 +// REQUIRES: lld +// FIXME: This may pass on Android, with non-emulated-tls. +// XFAIL: android int undefined(); // On i386 clang adds --export-dynamic when linking with ASan, which adds all -- 2.7.4