From 1c48146763d1754ea9c6491d06b4805c89c1ecd8 Mon Sep 17 00:00:00 2001 From: Jason Ekstrand Date: Thu, 19 Oct 2017 08:43:36 -0700 Subject: [PATCH] VK_KHR_variable_pointers: Delete an unused and invalid variable The %float_var variable was not being used in any way by the test. It was also invalid because it had the StorageBuffer storage class (so it's in external memory) but also had a constant initializer. The real variable being tested in these tests is %f32_ptr_var which has the Function storage class so a constant initializer is fine. Component: Vulkan VK-GL-CTS issue: https://gitlab.khronos.org/Tracker/vk-gl-cts/issues/686 Affects: dEQP-VK.spirv_assembly.instruction.graphics.variable_pointers.nullptr_graphics.opvariable_initialized_null_* dEQP-VK.spirv_assembly.instruction.graphics.variable_pointers.nullptr_graphics.opselect_null_or_valid_ptr_* Change-Id: I9e2f118b1c774a84c0b6900ef0db081cb5256c2f --- .../modules/vulkan/spirv_assembly/vktSpvAsmVariablePointersTests.cpp | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/external/vulkancts/modules/vulkan/spirv_assembly/vktSpvAsmVariablePointersTests.cpp b/external/vulkancts/modules/vulkan/spirv_assembly/vktSpvAsmVariablePointersTests.cpp index 758e7e5..755af0e 100644 --- a/external/vulkancts/modules/vulkan/spirv_assembly/vktSpvAsmVariablePointersTests.cpp +++ b/external/vulkancts/modules/vulkan/spirv_assembly/vktSpvAsmVariablePointersTests.cpp @@ -2466,7 +2466,6 @@ void addNullptrVariablePointersGraphicsGroup (tcu::TestCaseGroup* testGroup) // VARIABLES "%input = OpVariable %float_struct_ptr StorageBuffer \n" - "%float_var = OpVariable %sb_f32ptr StorageBuffer %c_null_ptr \n" ); const StringTemplate testFunction ( @@ -2488,7 +2487,7 @@ void addNullptrVariablePointersGraphicsGroup (tcu::TestCaseGroup* testGroup) "OpReturnValue %output_color\n" "OpFunctionEnd\n"); - // float_var has been inintialized to NULL. + // f32_ptr_var has been inintialized to NULL. // Now set it to the input variable and return it as output { GraphicsResources resources; -- 2.7.4