From 1c29961267a210bb8a3284f9ab36ac5076a3fb72 Mon Sep 17 00:00:00 2001 From: Paolo Carlini Date: Mon, 3 Oct 2011 15:28:47 +0000 Subject: [PATCH] hashtable.h (_Hashtable<>::insert(value_type&&), [...]): Don't define here... 2011-10-03 Paolo Carlini * include/bits/hashtable.h (_Hashtable<>::insert(value_type&&), insert(const_iterator, value_type&&)): Don't define here... * include/bits/unordered_set.h (__unordered_set<>, __unordered_multiset<>): ... define here instead. From-SVN: r179464 --- libstdc++-v3/ChangeLog | 9 ++++++- libstdc++-v3/include/bits/hashtable.h | 42 +++++++++++++------------------ libstdc++-v3/include/bits/unordered_set.h | 28 +++++++++++++++++++-- 3 files changed, 51 insertions(+), 28 deletions(-) diff --git a/libstdc++-v3/ChangeLog b/libstdc++-v3/ChangeLog index 449f606..31c6914 100644 --- a/libstdc++-v3/ChangeLog +++ b/libstdc++-v3/ChangeLog @@ -1,7 +1,14 @@ +2011-10-03 Paolo Carlini + + * include/bits/hashtable.h (_Hashtable<>::insert(value_type&&), + insert(const_iterator, value_type&&)): Don't define here... + * include/bits/unordered_set.h (__unordered_set<>, + __unordered_multiset<>): ... define here instead. + 2011-09-29 Jason Merrill * testsuite/util/testsuite_tr1.h (test_property): Avoid - ambguity. + ambiguity. 2011-10-01 François Dumont diff --git a/libstdc++-v3/include/bits/hashtable.h b/libstdc++-v3/include/bits/hashtable.h index a125f3e..95d06b2 100644 --- a/libstdc++-v3/include/bits/hashtable.h +++ b/libstdc++-v3/include/bits/hashtable.h @@ -374,14 +374,6 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION _M_insert_bucket(_Arg&&, size_type, typename _Hashtable::_Hash_code_type); - template - std::pair - _M_insert(_Arg&&, std::true_type); - - template - iterator - _M_insert(_Arg&&, std::false_type); - typedef typename std::conditional<__unique_keys, std::pair, iterator>::type @@ -393,38 +385,38 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION >::type _Insert_Conv_Type; + protected: + template + std::pair + _M_insert(_Arg&&, std::true_type); + + template + iterator + _M_insert(_Arg&&, std::false_type); + public: // Insert and erase _Insert_Return_Type insert(const value_type& __v) - { return _M_insert(__v, std::integral_constant()); } + { return _M_insert(__v, integral_constant()); } iterator insert(const_iterator, const value_type& __v) { return _Insert_Conv_Type()(insert(__v)); } - _Insert_Return_Type - insert(value_type&& __v) - { return _M_insert(std::move(__v), - std::integral_constant()); } - - iterator - insert(const_iterator, value_type&& __v) - { return _Insert_Conv_Type()(insert(std::move(__v))); } - template::value>::type> + std::enable_if<__and_, + std::is_convertible<_Pair, + value_type>>::value>::type> _Insert_Return_Type insert(_Pair&& __v) { return _M_insert(std::forward<_Pair>(__v), - std::integral_constant()); } + integral_constant()); } template::value>::type> + std::enable_if<__and_, + std::is_convertible<_Pair, + value_type>>::value>::type> iterator insert(const_iterator, _Pair&& __v) { return _Insert_Conv_Type()(insert(std::forward<_Pair>(__v))); } diff --git a/libstdc++-v3/include/bits/unordered_set.h b/libstdc++-v3/include/bits/unordered_set.h index 38350bc..12b7bda 100644 --- a/libstdc++-v3/include/bits/unordered_set.h +++ b/libstdc++-v3/include/bits/unordered_set.h @@ -63,7 +63,9 @@ _GLIBCXX_BEGIN_NAMESPACE_CONTAINER typedef typename _Base::hasher hasher; typedef typename _Base::key_equal key_equal; typedef typename _Base::allocator_type allocator_type; - + typedef typename _Base::iterator iterator; + typedef typename _Base::const_iterator const_iterator; + explicit __unordered_set(size_type __n = 10, const hasher& __hf = hasher(), @@ -103,6 +105,16 @@ _GLIBCXX_BEGIN_NAMESPACE_CONTAINER this->insert(__l.begin(), __l.end()); return *this; } + + using _Base::insert; + + std::pair + insert(value_type&& __v) + { return this->_M_insert(std::move(__v), std::true_type()); } + + iterator + insert(const_iterator, value_type&& __v) + { return insert(std::move(__v)).first; } }; templateinsert(__l.begin(), __l.end()); return *this; } + + using _Base::insert; + + iterator + insert(value_type&& __v) + { return this->_M_insert(std::move(__v), std::false_type()); } + + iterator + insert(const_iterator, value_type&& __v) + { return insert(std::move(__v)); } }; template