From 1c1365e374bfadf908eae02cded7abb9e672c9d4 Mon Sep 17 00:00:00 2001 From: Vladimir Zapolskiy Date: Wed, 30 Oct 2013 14:08:32 +0200 Subject: [PATCH] sysfs: return correct error code on unimplemented mmap() Both POSIX.1-2008 and Linux Programmer's Manual have a dedicated return error code for a case, when a file doesn't support mmap(), it's ENODEV. This change replaces overloaded EINVAL with ENODEV in a situation described above for sysfs binary files. Signed-off-by: Vladimir Zapolskiy Signed-off-by: Greg Kroah-Hartman --- fs/sysfs/file.c | 1 - 1 file changed, 1 deletion(-) diff --git a/fs/sysfs/file.c b/fs/sysfs/file.c index 0d7368d4..382db3c 100644 --- a/fs/sysfs/file.c +++ b/fs/sysfs/file.c @@ -477,7 +477,6 @@ static int sysfs_bin_mmap(struct file *file, struct vm_area_struct *vma) if (!sysfs_get_active(of->sd)) goto out_unlock; - rc = -EINVAL; if (!battr->mmap) goto out_put; -- 2.7.4