From 1bdad2e0421a56e16c0f4623e6320e1225cbe5ee Mon Sep 17 00:00:00 2001 From: Tristan Gingold Date: Fri, 18 Apr 2014 11:03:46 +0200 Subject: [PATCH] solib-darwin: simplify code. Use bfd_mach_o_get_base_address to extract load address. gdb/ * solib-darwin.c (darwin_solib_create_inferior_hook): Simplify code by using bfd_mach_o_get_base_address. --- gdb/ChangeLog | 5 +++++ gdb/solib-darwin.c | 20 ++------------------ 2 files changed, 7 insertions(+), 18 deletions(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index b00cca9..c9b914a 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,8 @@ +2014-04-18 Tristan Gingold + + * solib-darwin.c (darwin_solib_create_inferior_hook): Simplify + code by using bfd_mach_o_get_base_address. + 2014-04-17 Ulrich Weigand  * spu-tdep.c: Include "dwarf2-frame.h" and "ax.h". diff --git a/gdb/solib-darwin.c b/gdb/solib-darwin.c index a9989ea..03b51d5 100644 --- a/gdb/solib-darwin.c +++ b/gdb/solib-darwin.c @@ -524,26 +524,10 @@ darwin_solib_create_inferior_hook (int from_tty) load_addr = darwin_read_exec_load_addr (info); if (load_addr != 0 && symfile_objfile != NULL) { - CORE_ADDR vmaddr = 0; - struct mach_o_data_struct *md = bfd_mach_o_get_data (exec_bfd); - unsigned int i, num; + CORE_ADDR vmaddr; /* Find the base address of the executable. */ - for (i = 0; i < md->header.ncmds; i++) - { - struct bfd_mach_o_load_command *cmd = &md->commands[i]; - - if (cmd->type != BFD_MACH_O_LC_SEGMENT - && cmd->type != BFD_MACH_O_LC_SEGMENT_64) - continue; - if (cmd->command.segment.fileoff == 0 - && cmd->command.segment.vmaddr != 0 - && cmd->command.segment.filesize != 0) - { - vmaddr = cmd->command.segment.vmaddr; - break; - } - } + vmaddr = bfd_mach_o_get_base_address (exec_bfd); /* Relocate. */ if (vmaddr != load_addr) -- 2.7.4