From 1b5d97ddaab24e480ffb53c9afd7350ff8a5fc9a Mon Sep 17 00:00:00 2001 From: Lei Zhang Date: Fri, 2 Sep 2022 17:02:00 -0400 Subject: [PATCH] [mlir][spirv] Fix MaxVersion for ops after supporting v1.6 Reviewed By: ThomasRaoux Differential Revision: https://reviews.llvm.org/D133234 --- mlir/include/mlir/Dialect/SPIRV/IR/SPIRVCLOps.td | 2 +- mlir/include/mlir/Dialect/SPIRV/IR/SPIRVGLOps.td | 4 ++-- mlir/include/mlir/Dialect/SPIRV/IR/SPIRVMatrixOps.td | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/mlir/include/mlir/Dialect/SPIRV/IR/SPIRVCLOps.td b/mlir/include/mlir/Dialect/SPIRV/IR/SPIRVCLOps.td index 06047d8..524c375 100644 --- a/mlir/include/mlir/Dialect/SPIRV/IR/SPIRVCLOps.td +++ b/mlir/include/mlir/Dialect/SPIRV/IR/SPIRVCLOps.td @@ -25,7 +25,7 @@ class SPV_CLOp traits = []> : let availability = [ MinVersion, - MaxVersion, + MaxVersion, Extension<[]>, Capability<[SPV_C_Kernel]> ]; diff --git a/mlir/include/mlir/Dialect/SPIRV/IR/SPIRVGLOps.td b/mlir/include/mlir/Dialect/SPIRV/IR/SPIRVGLOps.td index e4f8487..1243f22 100644 --- a/mlir/include/mlir/Dialect/SPIRV/IR/SPIRVGLOps.td +++ b/mlir/include/mlir/Dialect/SPIRV/IR/SPIRVGLOps.td @@ -20,13 +20,13 @@ include "mlir/Interfaces/SideEffectInterfaces.td" // SPIR-V GLSL 4.50 opcode specification. //===----------------------------------------------------------------------===// -// Base class for all GL ops. +// Base class for all OpenGL ops. class SPV_GLOp traits = []> : SPV_ExtInstOp { let availability = [ MinVersion, - MaxVersion, + MaxVersion, Extension<[]>, Capability<[SPV_C_Shader]> ]; diff --git a/mlir/include/mlir/Dialect/SPIRV/IR/SPIRVMatrixOps.td b/mlir/include/mlir/Dialect/SPIRV/IR/SPIRVMatrixOps.td index 0f8516f..d45259f 100644 --- a/mlir/include/mlir/Dialect/SPIRV/IR/SPIRVMatrixOps.td +++ b/mlir/include/mlir/Dialect/SPIRV/IR/SPIRVMatrixOps.td @@ -124,7 +124,7 @@ def SPV_MatrixTimesScalarOp : SPV_Op<"MatrixTimesScalar", [NoSideEffect]> { let availability = [ MinVersion, - MaxVersion, + MaxVersion, Extension<[]>, Capability<[SPV_C_Matrix]> ]; -- 2.7.4