From 1b567af05190aed9ffdad664434aa287375fce54 Mon Sep 17 00:00:00 2001 From: Jordan Petridis Date: Thu, 11 Jun 2020 20:57:58 +0300 Subject: [PATCH] libvisual: use gst_element_class_set_metadata when passing dynamic strings gst_element_class_set_metadata is meant to only be used with static or inlined strings, which isn't the case for this element resulting in use-after-free later on. https://gstreamer.freedesktop.org/documentation/gstreamer/gstelement.html?gi-language=c#gst_element_class_set_static_metadata Part-of: --- ext/libvisual/visual.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ext/libvisual/visual.c b/ext/libvisual/visual.c index 2ed94f0..47ce29b 100644 --- a/ext/libvisual/visual.c +++ b/ext/libvisual/visual.c @@ -106,7 +106,7 @@ gst_visual_class_init (gpointer g_class, gpointer class_data) gst_element_class_add_static_pad_template (element_class, &src_template); gst_element_class_add_static_pad_template (element_class, &sink_template); - gst_element_class_set_static_metadata (element_class, + gst_element_class_set_metadata (element_class, longname, "Visualization", klass->plugin->info->about, "Benjamin Otte "); -- 2.7.4