From 1b4c87bf792e3c66aa57310d9b6f9ec57be723c4 Mon Sep 17 00:00:00 2001 From: "Eunki, Hong" Date: Thu, 20 Jul 2023 16:05:47 +0900 Subject: [PATCH] Fix coverity issue (copy data during iteration) Change-Id: I0c5eea6d07558513aca38f3a51d084973450b0ea Signed-off-by: Eunki, Hong --- dali/internal/system/common/async-task-manager-impl.cpp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/dali/internal/system/common/async-task-manager-impl.cpp b/dali/internal/system/common/async-task-manager-impl.cpp index eeb20a6..ce54421 100644 --- a/dali/internal/system/common/async-task-manager-impl.cpp +++ b/dali/internal/system/common/async-task-manager-impl.cpp @@ -349,7 +349,7 @@ void AsyncTaskManager::RemoveTask(AsyncTaskPtr task) auto mapIter = mCacheImpl->mWaitingTasksCache.find(task.Get()); if(mapIter != mCacheImpl->mWaitingTasksCache.end()) { - for(auto iterator : mapIter->second) + for(auto& iterator : mapIter->second) { DALI_ASSERT_DEBUG((*iterator) == task); if((*iterator)->GetPriorityType() == AsyncTask::PriorityType::HIGH) @@ -375,7 +375,7 @@ void AsyncTaskManager::RemoveTask(AsyncTaskPtr task) auto mapIter = mCacheImpl->mRunningTasksCache.find(task.Get()); if(mapIter != mCacheImpl->mRunningTasksCache.end()) { - for(auto iterator : mapIter->second) + for(auto& iterator : mapIter->second) { DALI_ASSERT_DEBUG((*iterator).first == task); // We cannot erase container. Just mark as canceled. @@ -397,7 +397,7 @@ void AsyncTaskManager::RemoveTask(AsyncTaskPtr task) auto mapIter = mCacheImpl->mCompletedTasksCache.find(task.Get()); if(mapIter != mCacheImpl->mCompletedTasksCache.end()) { - for(auto iterator : mapIter->second) + for(auto& iterator : mapIter->second) { DALI_ASSERT_DEBUG((*iterator) == task); mCompletedTasks.erase(iterator); -- 2.7.4