From 1b1de2d221a0ed23e529e91bf9fa3dc287acb2ca Mon Sep 17 00:00:00 2001 From: adamk Date: Mon, 10 Aug 2015 11:16:23 -0700 Subject: [PATCH] Make run-tests.py warn when it's not testing anything I've often been confused by an "all passed" run of the test script when it turned out that either all the tests I cared about were skipped or, more likely, I mistyped the name(s) of the tests I wanted to run. This patch aims to fix that (and gives a useful diagnostic for the "all matched tests were skipped" case). R=machenbach@chromium.org NOTRY=true Review URL: https://codereview.chromium.org/1283513003 Cr-Commit-Position: refs/heads/master@{#30095} --- tools/run-tests.py | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/tools/run-tests.py b/tools/run-tests.py index a3d4d0a..f467089 100755 --- a/tools/run-tests.py +++ b/tools/run-tests.py @@ -532,8 +532,6 @@ def Main(): def Execute(arch, mode, args, options, suites, workspace): - print(">>> Running tests for %s.%s" % (arch, mode)) - shell_dir = options.shell_dir if not shell_dir: if options.buildbot: @@ -651,6 +649,14 @@ def Execute(arch, mode, args, options, suites, workspace): if options.cat: return 0 # We're done here. + if num_tests == 0: + print("No tests selected for running!") + if len(all_tests) > 0: + verbose.PrintReport(all_tests) + return 0 + + print(">>> Running tests for %s.%s" % (arch, mode)) + if options.report: verbose.PrintReport(all_tests) -- 2.7.4