From 1a9bc3d8f6131ace0328b7c2bdd408a136cfbdfb Mon Sep 17 00:00:00 2001 From: Yu Watanabe Date: Sat, 30 Mar 2019 02:47:33 +0900 Subject: [PATCH] network: do not continue when appending data to netlink message fails --- src/network/netdev/tunnel.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/network/netdev/tunnel.c b/src/network/netdev/tunnel.c index 55d6f7a..244954e 100644 --- a/src/network/netdev/tunnel.c +++ b/src/network/netdev/tunnel.c @@ -141,7 +141,7 @@ static int netdev_gre_fill_message_create(NetDev *netdev, Link *link, sd_netlink r = sd_netlink_message_append_in_addr(m, IFLA_GRE_REMOTE, &t->remote.in); if (r < 0) - log_netdev_error_errno(netdev, r, "Could not append IFLA_GRE_REMOTE attribute: %m"); + return log_netdev_error_errno(netdev, r, "Could not append IFLA_GRE_REMOTE attribute: %m"); r = sd_netlink_message_append_u8(m, IFLA_GRE_TTL, t->ttl); if (r < 0) @@ -149,7 +149,7 @@ static int netdev_gre_fill_message_create(NetDev *netdev, Link *link, sd_netlink r = sd_netlink_message_append_u8(m, IFLA_GRE_TOS, t->tos); if (r < 0) - log_netdev_error_errno(netdev, r, "Could not append IFLA_GRE_TOS attribute: %m"); + return log_netdev_error_errno(netdev, r, "Could not append IFLA_GRE_TOS attribute: %m"); r = sd_netlink_message_append_u8(m, IFLA_GRE_PMTUDISC, t->pmtudisc); if (r < 0) @@ -224,7 +224,7 @@ static int netdev_erspan_fill_message_create(NetDev *netdev, Link *link, sd_netl r = sd_netlink_message_append_in_addr(m, IFLA_GRE_REMOTE, &t->remote.in); if (r < 0) - log_netdev_error_errno(netdev, r, "Could not append IFLA_GRE_REMOTE attribute: %m"); + return log_netdev_error_errno(netdev, r, "Could not append IFLA_GRE_REMOTE attribute: %m"); return r; } -- 2.7.4