From 1a41ff966b5e81d56978dbcb145464e887ff8b3e Mon Sep 17 00:00:00 2001 From: Haejeong Kim Date: Thu, 17 Aug 2017 16:27:54 +0900 Subject: [PATCH] Fix resource leak. db connection handle was not released. Change-Id: Ic10ef7dfef61e963aef18213b353025f21ea0901 --- src/dcm_svc_internal.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/dcm_svc_internal.c b/src/dcm_svc_internal.c index cd9b8c2..b399347 100755 --- a/src/dcm_svc_internal.c +++ b/src/dcm_svc_internal.c @@ -538,8 +538,11 @@ int dcm_scan_single(const char *file_path, uid_t uid, int *face_count) dcm_retvm_if(ret != MS_MEDIA_ERR_NONE, ret, "Fail dcm_svc_db_connect"); ret = dcm_svc_db_get_scan_image_info_by_path(file_path, &scan_item); - dcm_retvm_if(ret != MS_MEDIA_ERR_NONE, ret, "Fail dcm_svc_db_get_scan_image_info_by_path"); - dcm_retvm_if(scan_item == NULL, ret, "scan_item is NULL"); + if (ret != MS_MEDIA_ERR_NONE || scan_item == NULL) { + dcm_error("Failed to dcm_svc_db_get_scan_image_info_by_path err: %d", ret); + dcm_svc_db_disconnect(); + return ret; + } ret = __dcm_scan_process(scan_item); if (ret != MS_MEDIA_ERR_NONE) { -- 2.34.1