From 19a138adcfe60b0b90b5b18a94c2db65e24bfb61 Mon Sep 17 00:00:00 2001 From: Rob Clark Date: Mon, 27 Mar 2023 15:06:37 -0700 Subject: [PATCH] freedreno: Stop being too clever by half This wasn't taking into account a change in corresponding bit in writeable_bitmask, causing problem if an SSBO was first bound for read, and then rebound for write, we wouldn't update the buffers valid range. Instead just drop the premature optimization. Signed-off-by: Rob Clark Part-of: --- src/gallium/drivers/freedreno/freedreno_state.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/src/gallium/drivers/freedreno/freedreno_state.c b/src/gallium/drivers/freedreno/freedreno_state.c index 295be5a..5ca825a 100644 --- a/src/gallium/drivers/freedreno/freedreno_state.c +++ b/src/gallium/drivers/freedreno/freedreno_state.c @@ -172,11 +172,6 @@ fd_set_shader_buffers(struct pipe_context *pctx, enum pipe_shader_type shader, struct pipe_shader_buffer *buf = &so->sb[n]; if (buffers && buffers[i].buffer) { - if ((buf->buffer == buffers[i].buffer) && - (buf->buffer_offset == buffers[i].buffer_offset) && - (buf->buffer_size == buffers[i].buffer_size)) - continue; - buf->buffer_offset = buffers[i].buffer_offset; buf->buffer_size = buffers[i].buffer_size; pipe_resource_reference(&buf->buffer, buffers[i].buffer); -- 2.7.4