From 190163648138a4c8428fa594f3c00bdcba891e27 Mon Sep 17 00:00:00 2001 From: "aroben@apple.com" Date: Mon, 26 Sep 2011 12:15:28 +0000 Subject: [PATCH] Remove two failing WebKitAPITest tests The failures are covered by and . Reviewed by Anders Carlsson. * WebKitAPITest/tests/WebViewDestruction.cpp: Removed the NoCloseOrDestroyViewWindow and MainFrameAfterClose tests. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95943 268f45cc-cd09-0410-ab3c-d52691b4dbfc --- Tools/ChangeLog | 11 ++++++++++ Tools/WebKitAPITest/tests/WebViewDestruction.cpp | 26 ------------------------ 2 files changed, 11 insertions(+), 26 deletions(-) diff --git a/Tools/ChangeLog b/Tools/ChangeLog index c990529..b904f1b 100644 --- a/Tools/ChangeLog +++ b/Tools/ChangeLog @@ -1,3 +1,14 @@ +2011-09-23 Adam Roben + + Remove two failing WebKitAPITest tests + + The failures are covered by and . + + Reviewed by Anders Carlsson. + + * WebKitAPITest/tests/WebViewDestruction.cpp: Removed the NoCloseOrDestroyViewWindow and + MainFrameAfterClose tests. + 2011-09-25 Adam Barth Finish removing PLATFORM(BREWMP) by removing associated code diff --git a/Tools/WebKitAPITest/tests/WebViewDestruction.cpp b/Tools/WebKitAPITest/tests/WebViewDestruction.cpp index b7ae0b6..4ab3a6a 100644 --- a/Tools/WebKitAPITest/tests/WebViewDestruction.cpp +++ b/Tools/WebKitAPITest/tests/WebViewDestruction.cpp @@ -114,17 +114,6 @@ TEST(WebViewDestruction, CloseWithoutInitWithFrame) finishWebViewDestructionTest(webView, 0); } -// Tests that releasing a WebView without calling IWebView::close or DestroyWindow doesn't leak. -TEST(WebViewDestruction, NoCloseOrDestroyViewWindow) -{ - COMPtr webView; - HostWindow window; - HWND viewWindow; - createAndInitializeWebView(webView, window, viewWindow); - - finishWebViewDestructionTest(webView, viewWindow); -} - // Tests that calling IWebView::close without calling DestroyWindow, then releasing a WebView doesn't crash. TEST(WebViewDestruction, CloseWithoutDestroyViewWindow) { @@ -214,19 +203,4 @@ TEST(WebViewDestruction, CloseThenDestroyHostWindow) finishWebViewDestructionTest(webView, viewWindow); } -// Tests that calling IWebView::mainFrame after calling IWebView::close doesn't crash. -TEST(WebViewDestruction, MainFrameAfterClose) -{ - COMPtr webView; - HostWindow window; - HWND viewWindow; - createAndInitializeWebView(webView, window, viewWindow); - - TEST_ASSERT(SUCCEEDED(webView->close())); - COMPtr mainFrame; - TEST_ASSERT(SUCCEEDED(webView->mainFrame(&mainFrame))); - - finishWebViewDestructionTest(webView, viewWindow); -} - } // namespace WebKitAPITest -- 2.7.4