From 18da616da992ceb83f9e8a67cf692843e1e4aaa2 Mon Sep 17 00:00:00 2001 From: Aaron Kennedy Date: Fri, 27 May 2011 13:04:15 +1000 Subject: [PATCH] [V8] Fix warnings Change-Id: I0e11d9ae92d22a7af118a5b532284411a0e72775 Reviewed-by: Kent Hansen --- src/3rdparty/v8/include/v8.h | 21 ++++++++++++--------- 1 file changed, 12 insertions(+), 9 deletions(-) diff --git a/src/3rdparty/v8/include/v8.h b/src/3rdparty/v8/include/v8.h index 5be96f6..3416cd4 100644 --- a/src/3rdparty/v8/include/v8.h +++ b/src/3rdparty/v8/include/v8.h @@ -2616,7 +2616,7 @@ class V8EXPORT Extension { // NOLINT int source_length = -1); virtual ~Extension() { } virtual v8::Handle - GetNativeFunction(v8::Handle name) { + GetNativeFunction(v8::Handle) { return v8::Handle(); } @@ -3007,7 +3007,7 @@ typedef uintptr_t (*ReturnAddressLocationResolver)( class V8EXPORT ExternalResourceVisitor { // NOLINT public: virtual ~ExternalResourceVisitor() {} - virtual void VisitExternalString(Handle string) {} + virtual void VisitExternalString(Handle) {} }; @@ -3900,6 +3900,9 @@ class V8EXPORT OutputStream { // NOLINT * will not be called in case writing was aborted. */ virtual WriteResult WriteHeapStatsChunk(HeapStatsUpdate* data, int count) { + (void)data; + (void)count; + return kAbort; }; }; @@ -4098,13 +4101,13 @@ class Internals { return *reinterpret_cast(addr); } - static inline bool CanCastToHeapObject(void* o) { return false; } - static inline bool CanCastToHeapObject(Context* o) { return true; } - static inline bool CanCastToHeapObject(String* o) { return true; } - static inline bool CanCastToHeapObject(Object* o) { return true; } - static inline bool CanCastToHeapObject(Message* o) { return true; } - static inline bool CanCastToHeapObject(StackTrace* o) { return true; } - static inline bool CanCastToHeapObject(StackFrame* o) { return true; } + static inline bool CanCastToHeapObject(void*) { return false; } + static inline bool CanCastToHeapObject(Context*) { return true; } + static inline bool CanCastToHeapObject(String*) { return true; } + static inline bool CanCastToHeapObject(Object*) { return true; } + static inline bool CanCastToHeapObject(Message*) { return true; } + static inline bool CanCastToHeapObject(StackTrace*) { return true; } + static inline bool CanCastToHeapObject(StackFrame*) { return true; } }; } // namespace internal -- 2.7.4