From 18b5806ab92b0130a4231391b80a75cd5aae39b3 Mon Sep 17 00:00:00 2001 From: =?utf8?q?Rafa=C5=82=20Dzi=C4=99giel?= Date: Wed, 20 Jan 2021 13:38:03 +0100 Subject: [PATCH] assrender: Do not iterate over mimetypes without filename No point spending time on iterating and comparing strings if we are going to reject the value due to missing filename anyway. Part-of: --- subprojects/gst-plugins-bad/ext/assrender/gstassrender.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/subprojects/gst-plugins-bad/ext/assrender/gstassrender.c b/subprojects/gst-plugins-bad/ext/assrender/gstassrender.c index 64c796e..51c7987 100644 --- a/subprojects/gst-plugins-bad/ext/assrender/gstassrender.c +++ b/subprojects/gst-plugins-bad/ext/assrender/gstassrender.c @@ -1572,6 +1572,10 @@ gst_ass_render_handle_tag_sample (GstAssRender * render, GstSample * sample) if (!buf || !structure) return; + filename = gst_structure_get_string (structure, "filename"); + if (!filename) + return; + valid_mimetype = FALSE; valid_extension = FALSE; @@ -1585,10 +1589,6 @@ gst_ass_render_handle_tag_sample (GstAssRender * render, GstSample * sample) } } - filename = gst_structure_get_string (structure, "filename"); - if (!filename) - return; - if (!valid_mimetype) { guint len = strlen (filename); const gchar *extension = filename + len - 4; -- 2.7.4