From 18b467c0661d873554df0f6b1b359aa3459d25ca Mon Sep 17 00:00:00 2001 From: Matt Turner Date: Thu, 24 Jan 2019 11:51:14 -0800 Subject: [PATCH] intel/compiler: Add a file-level description of brw_eu_validate.c Acked-by: Jose Maria Casanova Crespo Reviewed-by: Iago Toral Quiroga Reviewed-by: Francisco Jerez --- src/intel/compiler/brw_eu_validate.c | 14 +++++++++++++- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/src/intel/compiler/brw_eu_validate.c b/src/intel/compiler/brw_eu_validate.c index a25010b..26fe292 100644 --- a/src/intel/compiler/brw_eu_validate.c +++ b/src/intel/compiler/brw_eu_validate.c @@ -1,5 +1,5 @@ /* - * Copyright © 2015 Intel Corporation + * Copyright © 2015-2019 Intel Corporation * * Permission is hereby granted, free of charge, to any person obtaining a * copy of this software and associated documentation files (the "Software"), @@ -24,6 +24,18 @@ /** @file brw_eu_validate.c * * This file implements a pass that validates shader assembly. + * + * The restrictions implemented herein are intended to verify that instructions + * in shader assembly do not violate restrictions documented in the graphics + * programming reference manuals. + * + * The restrictions are difficult for humans to quickly verify due to their + * complexity and abundance. + * + * It is critical that this code is thoroughly unit tested because false + * results will lead developers astray, which is worse than having no validator + * at all. Functional changes to this file without corresponding unit tests (in + * test_eu_validate.cpp) will be rejected. */ #include "brw_eu.h" -- 2.7.4