From 18a38dbfc1f64cc33a9e54b5c8f7dc392ec2628e Mon Sep 17 00:00:00 2001 From: Cheng Zhao Date: Tue, 14 Jun 2016 15:22:01 +0900 Subject: [PATCH] Fix exception in alert for inavlid parameter --- lib/renderer/override.js | 17 ++++------------- 1 file changed, 4 insertions(+), 13 deletions(-) diff --git a/lib/renderer/override.js b/lib/renderer/override.js index ced2318..c568388 100644 --- a/lib/renderer/override.js +++ b/lib/renderer/override.js @@ -154,20 +154,11 @@ window.open = function (url, frameName, features) { } // Use the dialog API to implement alert(). -window.alert = function (message, title) { - var buttons - if (arguments.length === 0) { - message = '' - } - if (title == null) { - title = '' - } - buttons = ['OK'] - message = String(message) +window.alert = function (message = '', title = '') { remote.dialog.showMessageBox(remote.getCurrentWindow(), { - message: message, - title: title, - buttons: buttons + message: String(message), + title: String(title), + buttons: ['OK'] }) } -- 2.7.4