From 18815322461f60e34160149ded6798d9d9304468 Mon Sep 17 00:00:00 2001 From: Nicholas Clark Date: Wed, 7 Dec 2011 13:55:03 +0100 Subject: [PATCH] bisect-runner.pl should skip the testcase if it fails to build config.sh Previously if given a testcase and a target of config.sh or config.h, it would always attempt run it, even if the target (config.sh or config.h) had not been built. Oddly enough, this usually resulted in the test case failing, with the consequence that the bisect run ended with a spurious result. Skipping such revisions instead makes the bisect output meaningful. --- Porting/bisect-runner.pl | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Porting/bisect-runner.pl b/Porting/bisect-runner.pl index be0ed7e..0bec743 100755 --- a/Porting/bisect-runner.pl +++ b/Porting/bisect-runner.pl @@ -917,6 +917,8 @@ if ($target =~ /config\.s?h/) { report_and_exit(!-f $target, 'could build', 'could not build', $target) if $options{'test-build'}; + skip("could not build $target") unless -f $target; + my $ret = system @ARGV; report_and_exit($ret, 'zero exit from', 'non-zero exit from', "@ARGV"); } elsif (!-f 'config.sh') { -- 2.7.4