From 1874058566fc403d05364e7a4f8047562057a485 Mon Sep 17 00:00:00 2001 From: Dom Cobley Date: Tue, 6 Dec 2022 15:05:56 +0000 Subject: [PATCH] vc4_hdmi: Avoid log spam for audio start failure We regularly get dmesg error reports of: [ 18.184066] hdmi-audio-codec hdmi-audio-codec.3.auto: ASoC: error at snd_soc_dai_startup on i2s-hifi: -19 [ 18.184098] MAI: soc_pcm_open() failed (-19) Currently I get 30 of these when booting to desktop. We always say, ignore they are harmless, but removing them would be good. A bit of investigation shows, for me, the errors are all generated by second, unused hdmi interface. It shows as an alsa device, and pulseaudio attempts to open it (numerous times), generating a kernel error message each time. systemctl --user restart pulseaudio.service generates 6 additional error messages. The error messages all come through: https://github.com/raspberrypi/linux/blob/a009a9c0d79dfec114ee5102ec3d3325a172c952/sound/soc/soc-pcm.c#L39 which suggests returning ENOTSUPP, rather that ENODEV will be quiet. And indeed it is. Note: earlier kernels do not have the quiet ENOTSUPP, so additional cherry-picks will be needed to backport Signed-off-by: Dom Cobley --- drivers/gpu/drm/vc4/vc4_hdmi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/vc4/vc4_hdmi.c b/drivers/gpu/drm/vc4/vc4_hdmi.c index 5391d48..c022078 100644 --- a/drivers/gpu/drm/vc4/vc4_hdmi.c +++ b/drivers/gpu/drm/vc4/vc4_hdmi.c @@ -2338,7 +2338,7 @@ static int vc4_hdmi_audio_startup(struct device *dev, void *data) } if (!vc4_hdmi_audio_can_stream(vc4_hdmi)) { - ret = -ENODEV; + ret = -ENOTSUPP; goto out_dev_exit; } -- 2.7.4