From 180ed714a186dcff27e9311f054f99bcc42da2b7 Mon Sep 17 00:00:00 2001 From: Jarkko Sakkinen Date: Thu, 13 Oct 2011 13:30:53 +0300 Subject: [PATCH] Fixed invalid return value in smack_rule_set_save(). Used mistakenly return value of fprintf(). --- src/smack.c | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/src/smack.c b/src/smack.c index 3ac0cbc..a90b2bc 100644 --- a/src/smack.c +++ b/src/smack.c @@ -144,9 +144,8 @@ int smack_rule_set_save(SmackRuleSet handle, int fd) int newfd; newfd = dup(fd); - if (newfd == -1) { + if (newfd == -1) return -1; - } file = fdopen(newfd, "w"); if (file == NULL) { @@ -160,16 +159,15 @@ int smack_rule_set_save(SmackRuleSet handle, int fd) ret = fprintf(file, "%s %s %s\n", rule->subject, rule->object, access_type); if (ret < 0) { - ret = -1; - goto out; + fclose(file); + return -1; } rule = rule->next; } -out: fclose(file); - return ret; + return 0; } int smack_rule_set_apply(SmackRuleSet handle, int flags) -- 2.7.4