From 17d5c697cd93c4d7887abc2cc13e3d062e4e2472 Mon Sep 17 00:00:00 2001 From: Karl Williamson Date: Fri, 2 Aug 2013 14:13:16 -0600 Subject: [PATCH] regcomp.h, sv.c, utf8.c: Comment nits Remove obsolete comment, typos in others, plus reflow one block to fit into 79 columns --- regcomp.h | 3 --- sv.c | 14 +++++++------- utf8.c | 2 +- 3 files changed, 8 insertions(+), 11 deletions(-) diff --git a/regcomp.h b/regcomp.h index 8b1b695..779ddfc 100644 --- a/regcomp.h +++ b/regcomp.h @@ -465,9 +465,6 @@ struct regnode_charclass_class { #define ANYOF_CLASS_TEST_ANY_SET(p) \ ((ANYOF_FLAGS(p) & ANYOF_CLASS) \ && (((struct regnode_charclass_class*)(p))->classflags)) -/*#define ANYOF_CLASS_ADD_SKIP (ANYOF_CLASS_SKIP - ANYOF_SKIP) - * */ - /* * Utility definitions. diff --git a/sv.c b/sv.c index 0e4ae37..99b23db 100644 --- a/sv.c +++ b/sv.c @@ -8652,13 +8652,13 @@ Perl_newSVpvn_flags(pTHX_ const char *const s, const STRLEN len, const U32 flags new_SV(sv); sv_setpvn(sv,s,len); - /* This code used to a sv_2mortal(), however we now unroll the call to sv_2mortal() - * and do what it does ourselves here. - * Since we have asserted that flags can only have the SVf_UTF8 and/or SVs_TEMP flags - * set above we can use it to enable the sv flags directly (bypassing SvTEMP_on), which - * in turn means we dont need to mask out the SVf_UTF8 flag below, which means that we - * eliminate quite a few steps than it looks - Yves (explaining patch by gfx) - */ + /* This code used to do a sv_2mortal(), however we now unroll the call to + * sv_2mortal() and do what it does ourselves here. Since we have asserted + * that flags can only have the SVf_UTF8 and/or SVs_TEMP flags set above we + * can use it to enable the sv flags directly (bypassing SvTEMP_on), which + * in turn means we dont need to mask out the SVf_UTF8 flag below, which + * means that we eliminate quite a few steps than it looks - Yves + * (explaining patch by gfx) */ SvFLAGS(sv) |= flags; diff --git a/utf8.c b/utf8.c index 4aaafba..bd729c2 100644 --- a/utf8.c +++ b/utf8.c @@ -3763,7 +3763,7 @@ Perl__swash_inversion_hash(pTHX_ SV* const swash) * * The returned hash would have two keys, the utf8 for 006B and the utf8 for * 006C. The value for each key is an array. For 006C, the array would - * have a two elements, the utf8 for itself, and for 004C. For 006B, there + * have two elements, the utf8 for itself, and for 004C. For 006B, there * would be three elements in its array, the utf8 for 006B, 004B and 212A. * * Essentially, for any code point, it gives all the code points that map to -- 2.7.4