From 17c45768fdf970b8a2ea9745783ff6a0512fca11 Mon Sep 17 00:00:00 2001 From: Greg Kroah-Hartman Date: Tue, 14 Feb 2023 08:59:33 +0100 Subject: [PATCH] Revert "driver core: add error handling for devtmpfs_create_node()" This reverts commit 31b4b6730fd4f5d503c9f23619c920ce7b794754 as it is reported to cause boot regressions. Link: https://lore.kernel.org/r/Y+rSXg14z1Myd8Px@dev-arch.thelio-3990X Reported-by: Nathan Chancellor Cc: Longlong Xia Signed-off-by: Greg Kroah-Hartman --- drivers/base/core.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/base/core.c b/drivers/base/core.c index 4fc6f27..f9297c6 100644 --- a/drivers/base/core.c +++ b/drivers/base/core.c @@ -3602,9 +3602,7 @@ int device_add(struct device *dev) if (error) goto SysEntryError; - error = devtmpfs_create_node(dev); - if (error) - goto DevtmpfsError; + devtmpfs_create_node(dev); } /* Notify clients of device addition. This call must come @@ -3660,8 +3658,6 @@ int device_add(struct device *dev) done: put_device(dev); return error; - DevtmpfsError: - device_remove_sys_dev_entry(dev); SysEntryError: if (MAJOR(dev->devt)) device_remove_file(dev, &dev_attr_dev); -- 2.7.4